Open
Conversation
- Introduced GitHubCli manager to handle package operations for GitHub repositories. - Implemented functionality to track repositories, find packages, and manage installations. - Added helper classes for package details and operations specific to GitHub CLI. - Updated project references and solution structure to include the new GitHub CLI manager. - Modified settings to accommodate tracked repositories for GitHub CLI. - Updated application version in the manifest.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds a new GitHub CLI–backed package manager to UniGetUI’s package engine so users can search GitHub repositories, track them, and download/install latest release assets via gh, while also reducing noisy icon-download errors.
Changes:
- Introduces a new
UniGetUI.PackageEngine.Managers.GitHubClimanager with release search, release-asset selection (arch-aware), download, and optional auto-install behavior. - Wires the new manager into the UI/settings page and package engine manager registry.
- Improves icon download handling (Content-Type handling + less noisy network/I/O error logging) and bumps build/version metadata.
Reviewed changes
Copilot reviewed 16 out of 17 changed files in this pull request and generated 8 comments.
Show a summary per file
| File | Description |
|---|---|
| src/WindowsPackageManager.Interop/ExternalLibraries.WindowsPackageManager.Interop.csproj | Uses $(TargetPlatformVersion) for CsWinRT metadata selection. |
| src/UniGetUI/app.manifest | App manifest version bump to 3.3.7.1. |
| src/UniGetUI/Pages/SettingsPages/ManagersPages/PackageManager.xaml.cs | Adds GitHub CLI manager to settings navigation type mapping. |
| src/UniGetUI.sln | Adds new GitHub CLI manager project to the solution + configs. |
| src/UniGetUI.PackageEngine.PackageEngine/UniGetUI.PackageEngine.PEInterface.csproj | References the new GitHub CLI manager project. |
| src/UniGetUI.PackageEngine.PackageEngine/PEInterface.cs | Registers GitHubCli instance and includes it in the Managers array. |
| src/UniGetUI.PackageEngine.Managers.GitHubCli/UniGetUI.PackageEngine.Managers.GitHubCli.csproj | New project for the GitHub CLI manager implementation. |
| src/UniGetUI.PackageEngine.Managers.GitHubCli/GitHubCli.cs | Core GitHub CLI manager logic (search, tracked repos, releases, gh invocations). |
| src/UniGetUI.PackageEngine.Managers.GitHubCli/Helpers/GitHubCliPkgDetailsHelper.cs | Package details + icon sourcing from GitHub API responses. |
| src/UniGetUI.PackageEngine.Managers.GitHubCli/Helpers/GitHubCliPkgOperationHelper.cs | Download/install/uninstall/update operation parameters and post-processing. |
| src/UniGetUI.Core.Settings/SettingsEngine_Names.cs | Adds settings key for tracked GitHub CLI repositories. |
| src/UniGetUI.Core.IconStore/IconCacheEngine.cs | Improves icon download robustness and logging (Content-Type + exception handling). |
| src/UniGetUI.Core.Data/CoreData.cs | Build number bump. |
| src/SharedAssemblyInfo.cs | Assembly version/file version bump to 3.3.7.1. |
| scripts/BuildNumber | Build number bump. |
| UniGetUI.iss | Updates version info and changes uninstall display name. |
| .gitignore | Ignores *.code-workspace. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
src/UniGetUI.PackageEngine.Managers.GitHubCli/Helpers/GitHubCliPkgDetailsHelper.cs
Show resolved
Hide resolved
src/UniGetUI.PackageEngine.Managers.GitHubCli/Helpers/GitHubCliPkgOperationHelper.cs
Outdated
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Any user suspected of farming GitHub activity with crypto purposes will get banned. Submitting broken code wastes the contributors' time, who have to spend their free time reviewing, fixing, and testing code that does not even compile breaks other features, or does not introduce any useful changes. I appreciate your understanding.
This PR improves the GitHubCLI manager release workflow end-to-end:
gh api search/repositories) when needed.x64/x86/arm64) using runtime hardware info..exe,.msi,.msix,.msixbundle,.appx).Downloadsdirectory.--archive zip) when no named assets exist.Additional stability fixes included in this branch:
Closes #4373