Check stderr for output to support google-test 1.17.0#506
Merged
matepek merged 1 commit intomatepek:masterfrom Feb 23, 2026
Merged
Check stderr for output to support google-test 1.17.0#506matepek merged 1 commit intomatepek:masterfrom
matepek merged 1 commit intomatepek:masterfrom
Conversation
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR checks output on
stderrif help output onstdoutdoesn't match when testing if framework is gtest.Which issue(s) this PR fixes:
This may fix #505, at least the portion related to discovering gtests.
Special notes for your reviewer:
I am not familiar with typescript or javascript, so this is my best attempt. Hopefully it is helpful. CONTRIBUTING.md says to make a PR to the development branch rather than
master, but it isn't clear which branch that is. Please update.