Skip to content

Check stderr for output to support google-test 1.17.0#506

Merged
matepek merged 1 commit intomatepek:masterfrom
christianLThomas:feature/support_gtest_1.17.0
Feb 23, 2026
Merged

Check stderr for output to support google-test 1.17.0#506
matepek merged 1 commit intomatepek:masterfrom
christianLThomas:feature/support_gtest_1.17.0

Conversation

@christianLThomas
Copy link
Contributor

@christianLThomas christianLThomas commented Feb 20, 2026

What this PR does / why we need it:
This PR checks output on stderr if help output on stdout doesn't match when testing if framework is gtest.

Which issue(s) this PR fixes:
This may fix #505, at least the portion related to discovering gtests.

Special notes for your reviewer:
I am not familiar with typescript or javascript, so this is my best attempt. Hopefully it is helpful. CONTRIBUTING.md says to make a PR to the development branch rather than master, but it isn't clear which branch that is. Please update.

@christianLThomas christianLThomas marked this pull request as draft February 20, 2026 16:52
@christianLThomas christianLThomas changed the title Check stderr for output to support 1.17.0 Check stderr for output to support google-test 1.17.0 Feb 20, 2026
@matepek matepek marked this pull request as ready for review February 23, 2026 11:09
@matepek matepek merged commit 57939ff into matepek:master Feb 23, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unit test to discover

2 participants