[Internal][CollapsingTextHelper] Fix letter spacing not updating correctly#5016
Open
pubiqq wants to merge 1 commit intomaterial-components:masterfrom
Open
Conversation
drchen
reviewed
Mar 13, 2026
| currentDrawY = lerp(expandedDrawY, collapsedDrawY, fraction, positionInterpolator); | ||
|
|
||
| setInterpolatedTextSize(fraction); | ||
|
|
Contributor
There was a problem hiding this comment.
Don't we need to keep this so the offset will be calculated correctly?
Contributor
Author
There was a problem hiding this comment.
Don't we need to keep this so the offset will be calculated correctly?
I'm not sure which offset you're referring to. The code block you highlighted is no longer needed because the updated calculateUsingTextSize() method already sets the correct letter spacing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the current implementation, when the letter spacing is changed, neither
currentLetterSpacingnor the text layout is updated, and this PR fixes that.Also it fixes #5014.