Update select.html from "var" to "const"#464
Merged
wuda-io merged 7 commits intomaterializecss:v2-devfrom Mar 8, 2024
Merged
Conversation
Release 2.0.3 🥶 Winter Edition
this was causing issue: failed to resolve entry for package "@materializecss/materialize materializecss#455
chore: do not include module section in package
very small fix for tabs: check for null content
Changed from "var" to "const" in line 157 und 162. Var ist outdated for Javascript const variables.
Member
|
Hi, thanks for your contribution. Please use commitlint format next time in the commit messages as suggested by @ChildishGiant. For example "docs: change var to const". Unfortunately the files you have changed have no effect on the documentation and have to be moved to materialize-docs. The PR will be added nevertheless. |
wuda-io
approved these changes
Mar 8, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changed from "var" to "const" in line 157 und 162. Var ist outdated for Javascript const variables.
Proposed changes
In current JavaScript, only const is used to create const variables. Var is outdated. Maybe you can change all var s into const for example in "Forms -> Select -> Initialization" or "Forms -> Select -> Methods".
Screenshots (if appropriate) or codepen:
Types of changes
Checklist: