fix/accessibility/enhancement(featureDiscovery) initialization, accessibility and spec test#537
Conversation
|
This pull-request is still work in progress, as I've found that when using buttons or other tabbable content inside the component it's currently not possible to tab from the open/close triggering element directly to the elements inside the Tap Target container |
This was more of a local issue where the triggering element was placed in an additional wrapper instead of near the tap-target element itself |
|
Update: Multiple instances not programmatically being initialized Accessibility
Implemented specification tests This pull request is ready for review |
…consistently since it was updated in setup in commit 6db4cc3
Proposed changes
Feature Discovery TapTarget trigger is not working as described in #523
This was caused by a bug where the initial triggering element was not handled within the event handler
In this fix I also addressed deleting the clone of the triggering element that initially handles closing the Feature Discover component by increasing the z-order on the initial trigger element and by a ternary operator to wether open/close the Feature Discovery when click event on this element is triggered
Multiple instances not programmatically being initialized #252
This also applies to #523 where a manual event handler needed to be defined in order to make the tap-targets work with the defined triggering element
Accessibility #541
Implemented specification tests
Specification tests have been implemented based on initializing, opening and closing the Feature Discovery component
Types of changes
Checklist: