Skip to content

Eslint coding standards#560

Merged
wuda-io merged 27 commits intomaterializecss:v2-devfrom
gselderslaghs:eslint-coding-standards
Dec 23, 2024
Merged

Eslint coding standards#560
wuda-io merged 27 commits intomaterializecss:v2-devfrom
gselderslaghs:eslint-coding-standards

Conversation

@gselderslaghs
Copy link
Member

@gselderslaghs gselderslaghs commented Dec 19, 2024

Proposed changes

Follow up of issue #506
Additional changes based on es coding standards configuration pull request #534, except for components where currently still are pull-requests open
There are still additional todo's regarding @typescript-eslint/no-explicit-any as I am looking for the correct type to declare on elements like (this.el as any).M_<componentName>, any suggestions on this one?

Guess we'll have two options to let the eslint pass:

  • apply the correct types
  • set @typescript-eslint/no-explicit-any to warning instead of error and create an additional issue to handle this in the future

Todo's:

  • Fix components in pull-requests after merge to v2-dev
  • fix additional @typescript-eslint/no-explicit-any errors
  • fix spec tests from failing eslint test

Types of changes

  • Bug fix (non-breaking change which fixes an issue).
  • New feature (non-breaking change which adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to change).

Checklist:

  • I have read the CONTRIBUTING document.
  • My commit messages follows the conventional commit format
  • My change requires a change to the documentation, and updated it accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

…ot removable when not initialized by init function
…ns of no options are defined, fixes no empty object type materializecss#506
@wuda-io wuda-io merged commit 4afb62e into materializecss:v2-dev Dec 23, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants