Add the optional ability to switch directories#100
Open
AlexDCraig wants to merge 1 commit intomathieudutour:masterfrom
Open
Add the optional ability to switch directories#100AlexDCraig wants to merge 1 commit intomathieudutour:masterfrom
AlexDCraig wants to merge 1 commit intomathieudutour:masterfrom
Conversation
Author
|
@mathieudutour any thoughts on this small but impactful change? |
mathieudutour
requested changes
Nov 16, 2021
Owner
mathieudutour
left a comment
mathieudutour
left a comment
There was a problem hiding this comment.
Thanks for the PR! A couple of notes
| try { | ||
| const originDirectory = process.cwd(); | ||
| process.chdir(repoPath); | ||
| console.log('Changed directory from ' + originDirectory + ' to ' + process.cwd()); |
Owner
There was a problem hiding this comment.
Suggested change
| console.log('Changed directory from ' + originDirectory + ' to ' + process.cwd()); | |
| core.info(`Changed directory from ${originDirectory} to ${process.cwd()}`); |
| process.chdir(repoPath); | ||
| console.log('Changed directory from ' + originDirectory + ' to ' + process.cwd()); | ||
| } catch (err) { | ||
| console.log('Error encountered when changing directory: ' + err); |
Owner
There was a problem hiding this comment.
I think we should fail the workflow if the chdir fails, otherwise it might lead to unexpected behaviors
| required: false | ||
| default: "false" | ||
| repo_path: | ||
| description: "Path relative to $GITHUB_WORKSPACE that contains the cloned repository." |
Owner
There was a problem hiding this comment.
Could you also update the doc in the README (with some info as to when you'd want to do that)?
|
@AlexDHoffer can you pls fix the code as per @mathieudutour's comments? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows the user to change the directory in which the tagging logic runs.