This repository was archived by the owner on Nov 25, 2024. It is now read-only.
[federation] Add make_leave & send_leave#535
Merged
APwhitehat merged 7 commits intomatrix-org:masterfrom Jul 11, 2018
Merged
Conversation
| // MakeLeave implements the /make_leave API | ||
| func MakeLeave( | ||
| ctx context.Context, | ||
| httpReq *http.Request, |
Member
There was a problem hiding this comment.
Surely you can just pass httpReq and then take the Context from that?
Contributor
Author
There was a problem hiding this comment.
yes, didn't notice this redundancy.
I wonder if we can change LogThenError to take just the httpReq.Context() instead of the whole request.
Contributor
There was a problem hiding this comment.
IIRC this split was made by intention...
| // SendLeave implements the /send_leave API | ||
| func SendLeave( | ||
| ctx context.Context, | ||
| httpReq *http.Request, |
erikjohnston
approved these changes
Jul 6, 2018
Member
erikjohnston
left a comment
erikjohnston
left a comment
There was a problem hiding this comment.
We probably also want to double check that the membership is set to leave, otherwise LGTM
Signed-off-by: Anant Prakash <anantprakashjsr@gmail.com>
Signed-off-by: Anant Prakash <anantprakashjsr@gmail.com>
Member
|
Oh, oops, you misunderstood what I meant, sorry. I meant that when we check that the various fields, like that |
erikjohnston
assigned
APwhitehat and
anoadragon453 and unassigned
anoadragon453 and
erikjohnston
Member
|
Thanks! :D |
anoadragon453
pushed a commit
that referenced
this pull request
Jul 16, 2018
* [federation] Add make_leave & send_leave * Remove redundant parameters * Check membership is set to leave Signed-off-by: Anant Prakash <anantprakashjsr@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mostly the same as make_join & send_join.