[Federation] Send typing events#572
Conversation
|
|
||
| import "github.com/matrix-org/gomatrixserverlib" | ||
|
|
||
| // TODO: Remove this package after, typingserver/api is updated to contain a gomatrixserverlib.Event |
There was a problem hiding this comment.
We should probably move this TODO out of dummy package now that the plan is no longer to change to using Event
| // The Event for the typing edu event. | ||
| Event TypingEvent `json:"event"` | ||
| // Users typing in the room at the event. | ||
| TypingUsers []string `json:"typing_users"` |
There was a problem hiding this comment.
Can you expand the OutputTypingEvent doc comment to explain why we're sending both a TypingEvent and list of currently typing users?
|
Nuances with the current implementation (forgot to mention earlier):
@erikjohnston: Hope you see this before accepting this PR. |
I've just got travis to remove the |
removing the origin field as well. |
Took a look at the origin of this, I believe this is used for logging only. |
P.S. dummy api is used to emulate the type of api.OutputTypingEvent.Event as gomatrixserverlib.Event, will be removed when #569 is fixed.
Signed-off-by: Anant Prakash <anantprakashjsr@gmail.com>