feat: Add system bus logic and refactor panctl#202
Open
VedantSawant616 wants to merge 1 commit intomatrix-org:masterfrom
Open
feat: Add system bus logic and refactor panctl#202VedantSawant616 wants to merge 1 commit intomatrix-org:masterfrom
VedantSawant616 wants to merge 1 commit intomatrix-org:masterfrom
Conversation
Collaborator
chookity-pokk
left a comment
chookity-pokk
left a comment
There was a problem hiding this comment.
Thanks for the contribution @VedantSawant616! Just a couple quick comments. It also seems like the tests are failing. You can run them locally after installing tox (pip install tox) and then run tox -e coverage which should run all the tests.
Comment on lines
+13
to
+16
| if bus_choice == "system": | ||
| return dbus.SystemBus() | ||
| elif bus_choice == "session": | ||
| return dbus.SessionBus() |
Collaborator
There was a problem hiding this comment.
Can you adjust the README to show these options?
| # Use the helper to get the bus | ||
| bus = get_bus(args.bus) | ||
|
|
||
| # TODO: Place daemon startup logic here |
Collaborator
There was a problem hiding this comment.
Is this PR ready for review? Seems like we've got a significant TODO here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this pull request introduces a new module to handle system bus interactions and refactors the
panctlutility to use it.changes include:
pantalaimon/bus_helper.pyto encapsulate system bus-related logic.panctl.pyto integrate with the newbus_helper.pymodule, improving the overall structure and readability of the utility.daemon.pyto support the new system bus functionality.these changes make the
panctlcommand-line utility more robust and maintainable by separating concerns and centralizing bus-related operations.