fix: xmpp should no longer send empty messages, ever#177
Open
selfhoster1312 wants to merge 1 commit intomatterbridge-org:masterfrom
Open
fix: xmpp should no longer send empty messages, ever#177selfhoster1312 wants to merge 1 commit intomatterbridge-org:masterfrom
selfhoster1312 wants to merge 1 commit intomatterbridge-org:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should not happen, but after filtering messages in #175 i ended up with a message with just the username. It wasn't the file upload being announced but rather that after no attachments were found, we didn't check if the
Textwas empty.This should not happen because the gateway should make sure a bridge doesn't receive a message with no text and no attachments. Maybe this should be fixed in #175 instead.