Repository navigation
Propagate missing values in degree-zero B-spline bases - #282
Open
lllleolin-max wants to merge 1 commit into
Open
lllleolin-max wants to merge 1 commit into
lllleolin-max wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Degree-zero B-splines are built from interval comparisons, which turn NaN inputs into all-zero rows. Higher degrees propagate NaN through arithmetic, so the missing-value policy currently depends on spline degree. Explicitly preserve missing values in the returned basis columns. Tests cover ordinary missing values, out-of-domain values under
extrapolation="na", retained valid interval coding, and default row dropping when a degree-zero spline is used in a formula.Validation: the added regression tests fail on main (
81e675b) and pass with this patch. Related tests:python -m pytest tests/transforms/test_basis_spline.py -q. Changed files passruff checkandruff format.