This repository was archived by the owner on Jan 20, 2021. It is now read-only.
Open
Conversation
added 30 commits
March 28, 2019 09:19
Fixes deadlock cause by locking mutex twice
Gumbleffmpeg states that Stream can't be started again after stop
If you add multiple tracks while Mumbledj is downloading next track, it can cause audio corruption bug.
SendPrivateMessage used dj.Client.Self.Channel.Users.Find method, which search for user only in current channel of MumbleDJ. Method corrected to find all users currently on server. Fixes matthieugrieger#5
Sample player would stop playing samples if another sample was requested, previous sample was still playing and it was its last playback.
Better not to add a track than start an earrape.
If private playlist was accessed, response would not contain items element. Accessing later items slice caused `panic: runtime error: index out of range`. This is similar issue to matthieugrieger#180
To resume the audio after pausing it, need to use !resume instead of !pause.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
to resume the audio, !resume tag needs to be used. not !pause tag.