fix(mavlink_passthrough): export operator<< for Result with MAVSDK_PUBLIC#2881
Open
evanofficial wants to merge 1 commit into
Open
fix(mavlink_passthrough): export operator<< for Result with MAVSDK_PUBLIC#2881evanofficial wants to merge 1 commit into
evanofficial wants to merge 1 commit into
Conversation
…BLIC Without the export macro the operator<< symbol has hidden visibility and is unreachable from outside libmavsdk.so, causing a linker error when consumers try to stream a MavlinkPassthrough::Result. Mirrors the declaration of the equivalent operator<< in MavlinkDirect. Fixes mavlink#2880.
julianoes
approved these changes
May 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
friend std::ostream& operator<<forMavlinkPassthrough::Resultinmavlink_passthrough.hppis missing theMAVSDK_PUBLICvisibility specifier, so the symbol is hidden inlibmavsdk.soand consumers hit a linker error when they try to stream aResult(e.g.std::cout << result;).The equivalent
operator<<forMavlinkDirect::Resultinmavlink_direct.hppalready usesMAVSDK_PUBLIC— this PR just mirrors that pattern for consistency.Fixes #2880.