Skip to content

3D Viewer fix and optimization#14357

Draft
jnomikos wants to merge 2 commits into
mavlink:masterfrom
jnomikos:dev-viewer-3d-fixes
Draft

3D Viewer fix and optimization#14357
jnomikos wants to merge 2 commits into
mavlink:masterfrom
jnomikos:dev-viewer-3d-fixes

Conversation

@jnomikos
Copy link
Copy Markdown
Contributor

@jnomikos jnomikos commented May 11, 2026

Description

  1. Added "keepSceneAlive" setting which keeps the 3D scene alive when going back to fly view. Ensures that the scene does not need to be reloaded on each entry into 3D view. I figured it might be useful to destroy the scene still on memory constrained devices, which is why I added a setting for it.

  2. Fix crash which occurs when switching between "Fly View" and "3D View".

Type of Change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update
  • Refactoring (no functional changes)
  • CI/Build changes
  • Other

Testing

  • Tested locally
  • Added/updated unit tests
  • Tested with simulator (SITL)
  • Tested with hardware

Platforms Tested

  • Linux
  • Windows
  • macOS
  • Android
  • iOS

Flight Stacks Tested

  • PX4
  • ArduPilot

Screenshots

Checklist

  • I have read the Contribution Guidelines
  • I have read the Code of Conduct
  • My code follows the project's coding standards
  • I have added tests that prove my fix/feature works
  • New and existing unit tests pass locally

Related Issues

#14343


By submitting this pull request, I confirm that my contribution is made under the terms of the project's dual license (Apache 2.0 and GPL v3).

jnomikos added 2 commits May 10, 2026 22:28
Added "keepSceneAlive" setting which keeps the 3D scene alive when
going back to fly view. Ensures that the scene does not need to be
reloaded on each entry into 3D view.
Specifically when "keepSceneAlive" is disabled. We manually clear
missionWaypointListModel onDestruction of Viewer3DVehicleItems.
@codecov
Copy link
Copy Markdown

codecov Bot commented May 11, 2026

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (master@779a09d). Learn more about missing BASE report.

Files with missing lines Patch % Lines
src/Settings/Viewer3DSettings.cc 0.00% 1 Missing ⚠️

❌ Your patch check has failed because the patch coverage (0.00%) is below the target coverage (30.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #14357   +/-   ##
=========================================
  Coverage          ?   25.45%           
=========================================
  Files             ?      766           
  Lines             ?    65569           
  Branches          ?    30316           
=========================================
  Hits              ?    16688           
  Misses            ?    37138           
  Partials          ?    11743           
Flag Coverage Δ
unittests 25.45% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/Settings/Viewer3DSettings.h 100.00% <ø> (ø)
src/Settings/Viewer3DSettings.cc 12.50% <0.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 779a09d...c568636. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link
Copy Markdown
Contributor

Build Results

Platform Status

Platform Status Details
Linux Passed View
Windows Passed View
MacOS Passed View
Android Passed View

All builds passed.

Pre-commit

Check Status Details
pre-commit Failed (non-blocking) View

Pre-commit hooks: 4 passed, 44 failed, 7 skipped.

Test Results

linux-coverage: 90 passed, 0 skipped
Total: 90 passed, 0 skipped

Code Coverage

Coverage Baseline Change
59.2% 59.3% -0.0%

Artifact Sizes

Artifact Size Δ from master
QGroundControl 216.82 MB -4.64 MB (decrease)
QGroundControl-aarch64 176.75 MB +0.01 MB (increase)
QGroundControl-installer-AMD64 134.71 MB +0.01 MB (increase)
QGroundControl-installer-AMD64-ARM64 77.31 MB +0.00 MB (increase)
QGroundControl-installer-ARM64 106.04 MB +0.01 MB (increase)
QGroundControl-linux 335.08 MB No change
QGroundControl-mac 187.09 MB No change
QGroundControl-windows 187.11 MB No change
QGroundControl-x86_64 171.93 MB -0.45 MB (decrease)
Total size decreased by 5.06 MB

Updated: 2026-05-11 03:26:31 UTC • Triggered by: Android

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant