3D Viewer fix and optimization#14357
Conversation
Added "keepSceneAlive" setting which keeps the 3D scene alive when going back to fly view. Ensures that the scene does not need to be reloaded on each entry into 3D view.
Specifically when "keepSceneAlive" is disabled. We manually clear missionWaypointListModel onDestruction of Viewer3DVehicleItems.
Codecov Report❌ Patch coverage is
❌ Your patch check has failed because the patch coverage (0.00%) is below the target coverage (30.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## master #14357 +/- ##
=========================================
Coverage ? 25.45%
=========================================
Files ? 766
Lines ? 65569
Branches ? 30316
=========================================
Hits ? 16688
Misses ? 37138
Partials ? 11743
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
Build ResultsPlatform Status
All builds passed. Pre-commit
Pre-commit hooks: 4 passed, 44 failed, 7 skipped. Test Resultslinux-coverage: 90 passed, 0 skipped Code Coverage
Artifact Sizes
Updated: 2026-05-11 03:26:31 UTC • Triggered by: Android |
Description
Added "keepSceneAlive" setting which keeps the 3D scene alive when going back to fly view. Ensures that the scene does not need to be reloaded on each entry into 3D view. I figured it might be useful to destroy the scene still on memory constrained devices, which is why I added a setting for it.
Fix crash which occurs when switching between "Fly View" and "3D View".
Type of Change
Testing
Platforms Tested
Flight Stacks Tested
Screenshots
Checklist
Related Issues
#14343
By submitting this pull request, I confirm that my contribution is made under the terms of the project's dual license (Apache 2.0 and GPL v3).