Skip to content

Cache handling#2

Merged
max-gaspers-scott merged 3 commits intomainfrom
cache_handling
Nov 12, 2025
Merged

Cache handling#2
max-gaspers-scott merged 3 commits intomainfrom
cache_handling

Conversation

@max-gaspers-scott
Copy link
Owner

@max-gaspers-scott max-gaspers-scott commented Nov 11, 2025

Summary by CodeRabbit

  • Chores

    • Updated package naming and versioning for wiki-api and related macro packages.
    • Bumped versions: wiki-api-macros 0.1.3 → 0.1.4, wiki-api 0.1.2 → 0.1.3.
    • Updated documentation URLs to reflect package naming changes.
  • Documentation

    • Added internal development guidelines documentation.

@coderabbitai
Copy link

coderabbitai bot commented Nov 11, 2025

Walkthrough

This PR renames the wiki-api-macros package to wiki-api2-macros, bumps version numbers across related crates, updates dependency references in Cargo.toml files, refreshes the import path for the macro in languages.rs, reformats src/app.rs, and adds AGENTS.md development documentation.

Changes

Cohort / File(s) Summary
Development Documentation
AGENTS.md
New file documenting build/lint/test commands, code style conventions, error handling patterns using anyhow, config loading fallbacks, and async patterns with Tokio.
Package Renaming & Versioning
wiki-api-macros/Cargo.toml, wiki-api-macros/README.md
Package name changed from wiki-api-macros to wiki-api2-macros; version bumped 0.1.3 → 0.1.4; documentation URL updated; README header updated to reflect new package name.
Dependency Updates
wiki-api/Cargo.toml
Package version bumped 0.1.2 → 0.1.3; dependency key updated from wiki-api-macros to wiki-api2-macros; dependency version bumped to 0.1.4.
Macro Import Update
wiki-api/src/languages.rs
Import path for parse_languages macro updated from wiki_api_macros::parse_languages to wiki_api2_macros::parse_languages.
Code Formatting
src/app.rs
Match arms and nested blocks reflowed and restructured for formatting; no logic or control-flow changes.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

  • Verify all references to wiki-api-macros have been updated to wiki-api2-macros across the codebase (confirm languages.rs is the only import location)
  • Ensure version consistency between wiki-api-macros/Cargo.toml and wiki-api/Cargo.toml dependency declaration
  • Confirm that the dependency path ../wiki-api-macros correctly resolves to the renamed package directory

Possibly related PRs

  • updated for a new cargo package #1: Updates package naming and references similar to this PR's renaming of wiki-api-macros to wiki-api2-macros, with corresponding updates to crate metadata and import paths.

Poem

🐰 A rabbit rebrand, version high,
From wiki-api-macros to the sky,
Dependencies dance with new-found names,
While app.rs gets formatting games,
And AGENTS.md shows the way!

Pre-merge checks and finishing touches

❌ Failed checks (1 warning, 1 inconclusive)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. You can run @coderabbitai generate docstrings to improve docstring coverage.
Title check ❓ Inconclusive The pull request title 'Cache handling' is vague and generic, using non-descriptive terms that don't clearly convey the actual changes made in the changeset. The changeset involves renaming wiki-api-macros to wiki-api2-macros, updating dependencies, and reformatting code. Consider a more specific title like 'Rename wiki-api-macros to wiki-api2-macros and update dependencies' or 'Update macro package naming and version bumps'.
✅ Passed checks (1 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch cache_handling

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 3159401 and ce0e05a.

⛔ Files ignored due to path filters (1)
  • Cargo.lock is excluded by !**/*.lock
📒 Files selected for processing (6)
  • AGENTS.md (1 hunks)
  • src/app.rs (2 hunks)
  • wiki-api-macros/Cargo.toml (1 hunks)
  • wiki-api-macros/README.md (1 hunks)
  • wiki-api/Cargo.toml (2 hunks)
  • wiki-api/src/languages.rs (1 hunks)
🧰 Additional context used
🧬 Code graph analysis (2)
wiki-api/src/languages.rs (1)
wiki-api-macros/src/lib.rs (1)
  • parse_languages (37-165)
src/app.rs (2)
src/action.rs (2)
  • single (142-146)
  • action (148-151)
wiki-api/src/page.rs (1)
  • title (78-87)
🔇 Additional comments (2)
wiki-api-macros/Cargo.toml (2)

1-23: Clarify the PR objective.

The PR title is "Cache handling," but the visible changes relate to package renaming from wiki-api-macros to wiki-api2-macros. Confirm whether cache handling is implemented in other files or if the PR title should be updated for accuracy.


2-3: Code changes are correct; regenerate test_search lock file.

The package rename in wiki-api-macros/Cargo.toml is properly reflected across the workspace:

  • Directory path reference in root workspace members remains "wiki-api-macros" (correct—refers to directory, not package name)
  • Dependency in wiki-api/Cargo.toml correctly updated to wiki-api2-macros
  • Package name and documentation URL in the file are consistent

However, test_search/Cargo.lock contains stale references to the old package name "wiki-api-macros". While test_search is a separate project (not a workspace member) and this doesn't break functionality, regenerate its lock file by running cargo update in the test_search/ directory to reflect the package rename.

@max-gaspers-scott max-gaspers-scott self-assigned this Nov 12, 2025
@max-gaspers-scott max-gaspers-scott merged commit 40fb36e into main Nov 12, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

Comments