Skip to content

chore(deps): update to electron 34.x.x#486

Merged
amaury1093 merged 4 commits into
max-mapper:masterfrom
setchy:chore/electron-33
Oct 10, 2025
Merged

chore(deps): update to electron 34.x.x#486
amaury1093 merged 4 commits into
max-mapper:masterfrom
setchy:chore/electron-33

Conversation

@setchy

@setchy setchy commented Oct 15, 2024

Copy link
Copy Markdown
Contributor

Update deps using ncu, most notably electron@34.x.x

Signed-off-by: Adam Setch <adam.setch@outlook.com>
Signed-off-by: Adam Setch <adam.setch@outlook.com>
@setchy

setchy commented Dec 1, 2024

Copy link
Copy Markdown
Contributor Author

bump to electron 33.2.1

@SeriousSem

Copy link
Copy Markdown

Any chance to merge it?

@setchy

setchy commented Feb 27, 2025

Copy link
Copy Markdown
Contributor Author

@amaury1093 👀

@setchy setchy changed the title chore(deps): update to electron 33.x.x chore(deps): update to electron 34.x.x Feb 27, 2025
@gobengo

gobengo commented Feb 27, 2025

Copy link
Copy Markdown
Contributor

If I read this right, it updates to < 34, so 33?

@setchy

setchy commented Feb 27, 2025

Copy link
Copy Markdown
Contributor Author

Good catch @gobengo - i had updated #481 last night. will push updates to this branch, too

Signed-off-by: Adam Setch <adam.setch@outlook.com>
@setchy

setchy commented Feb 27, 2025

Copy link
Copy Markdown
Contributor Author

Updated

@gobengo

gobengo commented Feb 27, 2025

Copy link
Copy Markdown
Contributor

@setchy awesome! thank you!
For now, I was just able to downgrade to electron 33 and use your branch (via git dep after adding a prepare script on my fork). yay

I made a PR to add the prepare script here so all the feature branches can easily be npm installed and still work
#489

Comment thread package.json Outdated
Co-authored-by: Benjamin Goering <171782+gobengo@users.noreply.github.com>
@gwleuverink

Copy link
Copy Markdown

Hey all, are there any plans updating the electron dependency to the latest (38)?

V33 has been EOL since end of April

Happy to PR something

@RobbieTheWagner

Copy link
Copy Markdown
Contributor

@max-mapper any chance of updating things here?

@RobbieTheWagner

Copy link
Copy Markdown
Contributor

@max-mapper Would you be interested in adding some maintainers? There is a lot that could be updated here.

@setchy

setchy commented Oct 10, 2025

Copy link
Copy Markdown
Contributor Author

@max-mapper Would you be interested in adding some maintainers? There is a lot that could be updated here.

same question for @amaury1093 :)

@amaury1093 amaury1093 merged commit f477647 into max-mapper:master Oct 10, 2025
@amaury1093

amaury1093 commented Oct 10, 2025

Copy link
Copy Markdown
Collaborator

@max-mapper Would you be interested in adding some maintainers? There is a lot that could be updated here.

Yes, definitely. If ever someone wants to be main maintainer, I'm open to step down as a backup one. Unfortunately I think only @max-mapper can do that.

@amaury1093

Copy link
Copy Markdown
Collaborator

Published menubar@9.5.2

@setchy

setchy commented Oct 10, 2025

Copy link
Copy Markdown
Contributor Author

Perhaps @max-mapper could add a few additional maintainers so the responsibility/workload can be shared/distributed 🤞

@setchy

setchy commented Oct 10, 2025

Copy link
Copy Markdown
Contributor Author

Published menubar@9.5.2

thank you. 🙇

this PR sat for a while - electron is now up to 38.x so I'll raise a separate PR to bump to that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants