Draft
Conversation
SilviaAmAm
force-pushed
the
feature/new-health-check-of
branch
2 times, most recently
from
a339eff to
a827d05
Compare
Added script to deduce the worker name (including the queue)
For the worker, the readiness file is created/deleted but not touched. Therefore it makes more sense to check it once at the beginning instead of continuously.
SilviaAmAm
force-pushed
the
feature/new-health-check-of
branch
from
a827d05 to
9ef32f3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the probes in Open Forms to use the new health checks.
I tested with latest (using these values https://github.com/maykinmedia/kubernetes-deployment/pull/48) since OF 3.5 is not released yet.
This PR cannot be merged yet, it requires 3.5.0 (or a tag with the new health checks) to be released and the version of the chart needs to be bumped.
All other changes needed for Open Forms 3.5.0 (in addition to the health checks) also still need to be included.