Makes it compatible with sigmac parser and includes a FP fix#1
Open
redsand wants to merge 6 commits intombabinski:mainfrom
Open
Makes it compatible with sigmac parser and includes a FP fix#1redsand wants to merge 6 commits intombabinski:mainfrom
redsand wants to merge 6 commits intombabinski:mainfrom
Conversation
…powershell "Get-wmiobject -class Win32_NetworkAdapter | where-object {$_.AdapterTypeID -eq 0 -or $_.AdapterTypeID -eq 9} | Select-object @{Name="MACAddress";Expression={$_.MACAddress}}, @{Name="Description";Expression={$_.Description}}, @{Name="ProductName";Expression={$_.ProductName}}| ConvertTo-Json
mbabinski
approved these changes
Nov 14, 2022
mbabinski
requested changes
Nov 14, 2022
Owner
mbabinski
left a comment
mbabinski
left a comment
There was a problem hiding this comment.
Thank you for these changes! The only changes I would request prior to merging is that we leave the windash modifier. I know this makes it incompatible with sigmac, however, my intent was to create rules compatible with pySigma, which is the newer, more fully-featured sigma conversion tool recommended for ongoing development by SigmaHQ. I fully support you in maintaining parallel rules without the windash modifier so that they are compatible with sigmac.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.