Merged
Conversation
There's been some changes in the last few years and Rubocop has stabilized. Now that it supports plugins, we should also pull in the rake and minitest plugins since both of those are part of how this gem is built.
Ruby 2.6 is EOL and Ruby 2.7 is now the minimum version still being supported by the Ruby maintainers
✌🏻old RVM cruft
Looks like URI#register_scheme was introduced in Ruby 3.1, but backported to the standalone URI ruby gem so there's a non-zero chance that an older Ruby version may end up with a newer URI library. To be safe, we should try both versions by failing back to explicitly using the class level variable if the new loader method fails.
I guess we don't call Hash[] on stuff anymore?
The core Actions that were used previously have had some updates and changes since the original Actions workflow was written.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
URI#register_schemebefore@@schemes