Skip to content

Makefile: --target-arch amd64 is completely wrong #4

@xtaran

Description

@xtaran

Makefile contains this line:

dpkg-buildpackage -us -uc -b --target-arch amd64

This is wrong from multiple points of view:

  • There is nothing architecture-dependent (it's a shell script after all!), so the package should be archicture all.
  • The architecture is already specified via debian/control, not the commandline. Should be all, not any there, too.
  • You don't know on which architecture the user will later use this script. Won't be installable on a Raspberry Pi which either has architecture armhf or arm64. The Architecture: any in debian/control already chooses the proper target architecture (the one of the host) by default, if you don't want to do cross-compiling for another architecture.

So please:

  • Just drop the --target-arch amd64 from Makefile completely.
  • Change Architecture: any to Architecture: all in debian/control.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions