feat(schemas): separate public from internal schema#29041
Open
feat(schemas): separate public from internal schema#29041
Conversation
Contributor
|
Tip: Review these changes grouped by change (recommended for most PRs), or grouped by feature (for large PRs). |
d706910 to
16892e6
Compare
Otherwise `ajv` rejects the value for not being a string.
- Avoid unnecessary `tsType`. - Avoid descriptions next to `$ref` (causes duplicate types). - Refine descriptions.
Compares build output between PR and base.
Move them to `examples` property where appropriate.
Removes type information, and required/optional state.
- Remove filler phrases. - Drop unnecessary leading articles. - Trim verbose explanations. - Condense wordy descriptions. - Shorten multi-sentence descriptions with unnecessary elaboration. - Remove "Avoid using this functinoaly" from `deprecated` status. - Replace multi-paragraph descriptions.
Accept `InternalSupportBlock` instead of `InternalCompatStatement`.
Prevent mixed type of `__compat` key.
Contributor
Author
|
@ddbeck Thank you for your review. I made some changes, and will pick this up again in two weeks. If you like, you can take another look in the mean time. |
Contributor
|
This pull request has merge conflicts that must be resolved before it can be merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a public schema for
data.json, separate from the internal browser/compat file schemas.Also refines the schema descriptions based on Daniel's feedback.
Test results and supporting details
There are two changes that are strictly speaking breaking:
CompatStatement.source_fileproperty is now required.BrowserStatement.upstreamproperty is narrowed down toUpstreamBrowserName, a subset ofBrowserName.Before
After
diff
Related issues
Fixes #29059.