This repository was archived by the owner on Aug 30, 2021. It is now read-only.
[hotfix] SeedDB missing in env config#1025
Merged
lirantal merged 1 commit intomeanjs:masterfrom Oct 29, 2015
Merged
Conversation
Adds a check for the existence of the seedDB config setting, before attempting to read config.seedDB.seed setting. Solves the problem when the seedDB config setting is missing from a environment config, that causes the application to throw an exception at startup. Also, adds the seedDB setting to the Cloud-Foundry env config.
mleanos
force-pushed
the
seeddb-missing-config
branch
from
d04b284 to
28f1f57
Compare
Contributor
|
@mleanos I just tested your branch and it worked for me so this should be good to commit |
Member
|
LGTM |
Member
|
Changing to 0.4.2 so we can merge this defect in quickly. |
Member
|
LGTM |
1 similar comment
Member
|
LGTM |
lirantal
added a commit
that referenced
this pull request
Oct 29, 2015
[hotfix] SeedDB missing in env config
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a check for the existence of the seedDB config setting, before
attempting to read config.seedDB.seed setting.
Solves the problem when the seedDB config setting is missing from a
environment config, that causes the application to throw an exception at
startup.
As pointed out by @ryanjbaxter, due to the
seedDBsetting missing from the Cloud-Foundry env config.