Skip to content

Adds Typescript Types Compilation#420

Open
AdelinoGP wants to merge 1 commit intomeggsimum:mainfrom
AdelinoGP:typescript-typing
Open

Adds Typescript Types Compilation#420
AdelinoGP wants to merge 1 commit intomeggsimum:mainfrom
AdelinoGP:typescript-typing

Conversation

@AdelinoGP
Copy link
Copy Markdown

Thanks for your work on this librar, it's been really useful.

I noticed there was a previous attempt to convert the project to TypeScript. Instead of changing the existing codebase, this pull request adds a TypeScript declaration generation step (.d.ts) using the current JSDoc annotations as the source of truth. This provides TypeScript support for consumers while keeping the implementation in JavaScript.

@chrismayer
Copy link
Copy Markdown
Collaborator

Hi @AdelinoGP, thank you very much for this. Since I am not a TypeScript guy I cannot fully check/review your code. But I really like the general idea deriving the types from the current code. Two little questions:

  1. When I got it right, there should be no impact in the "normal" vanilla JS version of the software, right?

  2. Would you be availbale for possible upcoming questions popping up here once the TypeScript support is merged in the geoserver-node-client?

Thanks in advance.

@chrismayer
Copy link
Copy Markdown
Collaborator

Hi @AdelinoGP , are there any news on this? Thanks in advance...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants