Skip to content

Add Slack integration#286

Merged
jabelone merged 7 commits intomembermatters:devfrom
ctrlh:slack-integration
Jan 11, 2025
Merged

Add Slack integration#286
jabelone merged 7 commits intomembermatters:devfrom
ctrlh:slack-integration

Conversation

@sibios
Copy link
Copy Markdown

@sibios sibios commented Dec 29, 2024

Utilize Slack webhooks for notifications similar to the existing discord notifications. Minor tweak on wording to allow for notifications on door bumps.

Fixes: #280

Copy link
Copy Markdown
Member

@jabelone jabelone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great, thanks! Just have a few small changes suggested and it should be good to merge. I haven't physically tested this branch myself, but it looks fine to me once those changes are made.

@jabelone
Copy link
Copy Markdown
Member

jabelone commented Jan 5, 2025

Oh also looks like you may need to run black to auto format a couple things :) https://github.com/membermatters/MemberMatters/actions/runs/12531411171/job/35163781642?pr=286

@sibios
Copy link
Copy Markdown
Author

sibios commented Jan 5, 2025

these two additional commits should cover the requested changes. Please let me know if you think anything else should be modified for the PR to be merged. I have left as a TODO (probably need to cut an issue) to generic-ize the "Report via webhook" feature either (1) turning that into a abstract class for specific service classes to implement or (2) providing some sort of minimal templating DSL for admins to provide, have MM render, and then sling at a specified webhook.

@sibios sibios requested a review from jabelone January 5, 2025 19:57
@jabelone jabelone merged commit c718913 into membermatters:dev Jan 11, 2025
@jabelone
Copy link
Copy Markdown
Member

Thanks, merged :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants