Enhance/system config eks/#2842/#165

[Zanda256]

Description

This PR fixes #165

Notes for Reviewers

Signed commits

• Yes, I signed my commits.

[warunicorn19]

Hey @Zanda256 let's discuss this on the meshery dev call.

[Zanda256]

Hey @Zanda256 let's discuss this on the meshery dev call.

Sure, I'm available.

[hexxdump]

@Zanda256
Please use the below path for storing the backup config files:

	home, err := os.UserHomeDir()
	if err != nil {
		log.Warn("failed to get user home directory")
	}
	tmpArch = filepath.Join(home, ".meshery", "config"+t+".yaml")

[leecalcote]

Heads-up: there's a merge conflict here.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[alphaX86]

@Zanda256 @hexxdump are we still looking to fix the EKS issue or is this already resolved in other PR?

[Zanda256]

@alphaX86 , the implementation we had was working just fine, at least for the part of writing the EKS config to the local file, but then POSTing that context to the /api/system/kubernetes endpoint was failing here. So subsquent calls to kubectl would still use the old config.

[alphaX86]

I see... The PR has been left in the middle, that's why I've asked

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[stale]

This issue is being automatically closed due to inactivity. However, you may choose to reopen this issue.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[acald-creator]

bump...

Can anyone provide some details on this PR?

[Zanda256]

bump...

Can anyone provide some details on this PR?

Yes sure. This pr is meant do make a function that eliminates depency of the system config eks command on the aws cli. So the user can still execute the command even if they do not have the aws cli installed. We do huddle and go over any details. @acald-creator if you want to pick it up.

[leecalcote]

@Althaf66 thoughts on this?