[Feature Request]: Deprecate packets with missing/invalid HopStart

[agt]

Platform

Cross-Platform

Description

As a concrete step towards deprecating older firmware (more generally discussed in #7131), this feature request proposes a change to handling of packets from <=2.2 nodes:

When processing a packet with HopStart unset (i.e. 0) or invalid (hopLimit > HopStart):

1. Treat hopLimit as 0 and do not retransmit over LoRA or send via MQTT/UDP
2. Do not cancel scheduled or upcoming CLIENT (re)transmissions on the basis of this packet

Nodes <2.3 leave the field uninitialized or zero when the packet is first created, and in many cases will clear a previously-set valid HopStart when forwarding.

Limiting propagation and flood-algorithm impact will not only help rein in older clients but also can blunt some of the damage unmaintained (and likely inappropriately designated) router roles cause.

If project members support the concept I’m willing to write & submit a PR.

[kamcio2603]

+100, we need this!

[thebentern]

We would welcome a PR. :-)

If project members support the concept I’m willing to write & submit a PR.

[garthvh]

Seems like a great idea to me.

[GUVWAF]

With proper announcement this seems reasonable to me at this time. 2.3 came out March last year.

[b8b8]

Could even be taken a step further and not include pre 2.5 (pki) nodes at some point, but limiting that router owners with their own toggle might be more appropriate for that added firmware restriction.

[agt]

Thanks all for the feedback, I've started digging through the code and expect I'll soon jump on the Discord with questions.

[kamcio2603]

soon? any update?