-
-
Notifications
You must be signed in to change notification settings - Fork 2k
Enhancement/nested telemetry protos #9489
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
oscgonfer
wants to merge
125
commits into
meshtastic:develop
Choose a base branch
from
fablabbcn:enhancement/nested-telemetry-protos
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Enhancement/nested telemetry protos #9489
oscgonfer
wants to merge
125
commits into
meshtastic:develop
from
fablabbcn:enhancement/nested-telemetry-protos
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Hannes Fuchs <hannes.fuchs+git@0xef.de>
* Cleanup of SEN5X specific code added from switching branches * Remove SCAN_I2C_CLOCK_SPEED block as its not needed * Remove associated functions for setting I2C speed
* Unify build_epoch replacement logic in platformio-custom * Missed one
In the logs was: "No screen resolution defined in build_flags. Please define DISPLAY_SIZE." set according to similar devices.
* Put guards in place around debug heap operations * Add macros to clean up code * Add pointer as well
…-bluetooth-memory-leak Fix memory leak in `NRF52Bluetooth`: allocate `BluetoothStatus` on stack, not heap
* Fixes difference between idle and sleep * In LowPower, sleep is disabled * Requires testing for I2C clock comms for commands
* Fix not reclocking back to 700000Hz
* The logic in AQ module is different to the one in EnvironmentTelemetryModule. In Env module, if any sensor fails to getMetrics, no valid flag for the module. This prevents other sensors to report data.
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rebased onto #7198 (and #7245) for demo purposes. Still draft as it may make breaking changes in other clients if accepted.
This is a proposal to make
Telemetrywith nested protos (now only in AQ telemetry, but can be expanded to other telemetry modules) to add information regarding sensors in the payload (i.e. who is producing the data).Related to #9474 and building on protobufs proposal in meshtastic/protobufs#852.
An additional improvement would be to add other values (serial number, or sensor_id/sensor_name).