Improved Periodic class

[harry-iii-lord]

Hello folks.

I wanted to propose a small extension of current Periodic class to make it more c++ friendly (or so called more modern). Idea behind is to use std::function to hold callback.

Having class in such form give you ability of making nice encapsulation of functionalities without need to declaring C-style callbacks, for instance this way:

class Broadcaster2
{
public:
    Broadcaster2(const char *message) 
    {
        m_periodic = new Periodic("Broadcaster2", [this](){
            return this->callback();
        });
        //rest of code
    }

    int32_t callback() 
    {
        // something
        return 1;
    }

private:
    concurrency::Periodic *m_periodic;
    std::string m_message;
};

Proposed code is keeping existing C-style ctor, thus such change should be backward compatible.
Unfortunately such change is not binary equal (there is a member m_callback) and is bit bigger. Not sure this is that big issue. Leaving to your consideration.

Happy reviewing.

[github-actions]

@harry-iii-lord, Welcome to Meshtastic!

Thanks for opening your first pull request. We really appreciate it.

We discuss work as a team in discord, please join us in the #firmware channel.
There's a big backlog of patches at the moment. If you have time,
please help us with some code review and testing of other PRs!

Welcome to the team 😄

[jp-bennett]

Looks like this PR unintentionally picked up changes in the device-install scripts. The flash size change is a mere 80 bytes.

[CLAassistant]

All committers have signed the CLA.

[harry-iii-lord]

Looks like this PR unintentionally picked up changes in the device-install scripts. The flash size change is a mere 80 bytes.

Indeed. It wasn't intention :) and I see you fix that. Thank you.

[Copilot]

Pull request overview

Extends the concurrency::Periodic thread helper to support “modern” C++ callables (via std::function) in addition to the existing legacy function-pointer callback, enabling lambdas and member-function captures while keeping source compatibility.

Changes:

• Add std::function<int32_t()>-based constructor overload for Periodic.
• Replace the raw function pointer member with a std::function callback invocation path.
• Update class docstring to reflect dual callback support.

[Copilot]

std::move(cb) is used in the std::function constructor, but this header does not include <utility> (the standard header that provides std::move). Relying on it being pulled in transitively via <functional> is not portable; please add #include <utility> (or avoid std::move here).

[harry-iii-lord]

That make sense. I will add it.

[Copilot]

m_callback is declared under protected:, which changes it from the previous implicit-private member (callback) and exposes it to subclasses. To keep the Periodic scheduling behavior encapsulated and avoid unintended mutation from derived classes, make the callback member private (keeping only runOnce() protected).

Suggested change

	int32_t runOnce() override { return m_callback ? m_callback() : 0; }
	int32_t runOnce() override { return m_callback ? m_callback() : 0; }
	private:

[harry-iii-lord]

Ok. Wil change that.

[Copilot]

Member naming here (m_callback) introduces an m_ prefix that doesn’t match the surrounding concurrency code’s member style (typically plain camelCase, e.g. controller in concurrency/OSThread.h:33 and notification in concurrency/NotifiedWorkerThread.h:16). Consider renaming to callback/callbackFn (and keep consistent casing) to match established conventions.

[harry-iii-lord]

This make sense too.