[DO NOT LAND] Test run for MLP bias accuracy issue#609
Open
xuzhao9 wants to merge 6 commits into
Open
Conversation
ee418eb to
1daafda
Compare
921b3bc to
37727f5
Compare
Contributor
Author
|
Closing as this is nvidia kernel issue. |
Contributor
Author
|
A minimal reproduction: After discussing with PyTorch developers, it is because post_grad pass will decompose addmm into mm and add by default, and it needs to set torch.mm(..., out_dtype=torch.float32) to make the result consistent with torch.addmm(). |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
torch.compile has numeric issue with used with torch.amp.autocast and bias
The problem is gone when:
#607
Reproduce:
The issue is not related to amp. It is only related to the post_grad pass of pt2 where it decomposes addmm into mm + triton add. This should be easily reproduced with a simpler test.