Repository navigation
fix(test): repair demo seed false pass and measure collection floor - #1000
Merged
Merged
Conversation
mforce
force-pushed
the
docs/863-collection-measurement
branch
from
September 30, 2026 03:10
c6d1353 to
6b2babf
Compare
This was referenced Sep 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Issue #863 asks for evidence before splitting the serialized integration collection. The measurement found that
DemoSeedTests.DemoSeed_PopulatesEveryScreen_AndIsIdempotentpassed without performing its first seed: the boot fact had already populated the shared default account.Change
SeedStatus.Seededon the first call andSeedStatus.AlreadySeededon the second.AccountProvisioningTestsa distinct fixture because its failed-provisioning checks compare database-wide counts.docs/plans/863-integration-collection-split/01-measurement.md.Evidence and decision
The first-call assertion went red with the old fixture: expected
Seeded, actualAlreadySeeded. The focused green run passed 21 tests. The full local integration run and four PR CI runs each passed all 1,873 tests. Local process wall time changed from 416.7 to 395.3 seconds; the shared span changed from 403.5 to 383.0 seconds. PR CI test steps ranged from 390.4 to 605.9 seconds. Across the four runs, the shared-only tail was absent or at most 23.5 seconds. A width-two split has a conditional ceiling of about 4% before extra fixture cost; the document recommends do not split.The staged documentation passed
SchemaDocsTests.PostgresImagePin_IsOneIdenticalStringAcrossEveryTrackedFile.Refs #863. The issue remains open for a later split decision if the CI schedule changes.