[mforce]

Closes #133.

Decision

#133 asked whether the remaining inline capture forms should become dialogs. The call, matching the issue's own analysis:

• Users flock-assignment — moved to a dialog. Not a judgement call: it's a per-row action, so it should match the neighbours Inline add/edit forms → modal dialogs (less-intrusive capture) #131 migrated. It was simply missed.
• Water / Daily entry / expense-add / Sales draft-line — stay inline. The form is the screen (Water, Daily entry — a dialog is an extra step on every daily visit), or a dialog-per-line would grate (Sales). The Help "Adding & correcting" section already documents why, so no change there.

What changed

The worker row's flocks button now opens a "Flock access — <email>" dialog (the shared Dialog, same contract as #131) holding the assignment list, per-row remove, and the assign control. Assign/remove refresh in place and keep it open; errors show inside it. Closes via Done / the X / Escape / backdrop — the old hide flocks toggle is gone.

Tests

382 pass. UsersPage suite updated to open-the-dialog-first (assert on the dialog by its accessible name, close via Done); UsersPage.tsx 98.5%. Coverage above floor (90.68 / 84.53 / 71.45). tsc + vite build clean.

Docs

Help "Adding & correcting" drill-down list gains "a worker's flocks to manage their access." No new user-facing term (flock assignment is already glossed), and the inline-capture list there already records the keep-inline decision — so no GLOSSARY / glossary-table change.

Part of epic #14 (Phase 1.1) — this closes the last open item in the phase.

[mforce]

Review round complete — codex + 2 Claude agents + pi

All four ran. The dialog wiring itself was confirmed sound (error guard, closed-state title, close behavior, tests, Help doc all correct). Two real issues, both fixed:

Async race on switching workers (feature-dev, confidence 85; pi independently, Medium; codex pointed at the same area + the InventoryPage re-validate idiom)

• onAssign/onUnassign captured openUser in a closure and wrote the post-await refresh back unconditionally. Since Done/Escape/backdrop aren't gated on busy, you could remove for worker A → close → open worker B while A's refresh was in flight, and A's assignment list (or a misattributed error) would splice into B's open dialog. pi flagged the mirror case in openAssignments (rapid A→B, out-of-order responses).
• Fix: an activeUser ref tracks the live dialog target; every post-await commit in openAssignments, onAssign, and onUnassign applies only while it still matches the request's target. New test: switch-workers-mid-refresh proves the stale list is discarded.

Stale assign dropdown (cavecrew; pi Low)

• The assign select kept the previous worker's pick across opens. Fix: reset to the first active flock on each open. New test guards it.

feature-dev downgraded the dropdown to a nit and pi called the race pre-existing — kept both fixes anyway; they're cheap and correct. 384 tests pass, UsersPage.tsx 97.65%, coverage above floor, tsc + vite build clean, tree clean before/after each external run. CI re-running on the push.