Repository navigation
test(web): pin the two #703 PR 3 residual guards (Stock key rotation, History void→adjust close) - #714
Merged
Conversation
) The #163 clearKey-before-refresh ordering is ungated by current(): the key rotates even when the write-off dialog is dismissed before the write settles, so a reopened same-lot dialog cannot reuse the spent key. The pre-existing 'even if the refresh fails' test exercises only the non-superseded path. Verified: a mutant moving clearKey below the current() gate reddens this test; the literal issue mutant (clearKey below the refresh try/catch, above the gate) is an equivalent mutant (the refresh is caught, so only position vs the gate is observable).
) Voiding an entry whose adjust dialog is open force-closes that dialog on the void's SUCCESS path; the 409 twin was pinned by #491 tests, the success twin was not. Verified: deleting the success-branch close reddens this test.
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This was referenced Sep 8, 2026
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #708 and #709 — both test-only; the shipped code is correct.
What
StockPage.test.tsx: a write-off dismissed before the write settles still rotates the idempotency key, so a reopened same-lot dialog mints a fresh key (the Users — Name can be set at creation and edited afterwards (API + SPA) #163clearKey-before-refresh ordering is a fact about the world, ungated bycurrent()). The pre-existing "even if the refresh fails" test covers only the non-superseded path.HistoryPage.test.tsx: voiding an entry whose adjust dialog is open force-closes that dialog on the void success path. The 409 twin was pinned by the fix(web): give every dialog screen its own error slot (#479) #491 tests; the success twin was not.Mutation evidence (driver-run)
clearKeybelow theif (!current()) returngate) → RED on the named assertion (keys equal). The literal issue mutant (clearKey below the refresh try/catch, above the gate) is an equivalent mutant — the refresh is caught, so onlyclearKey's position vs the gate is observable; this test pins that observable property.if (adjusting?.id === e.id) { setAdjusting(null); dismissDialog("adjust"); }) → RED on the named assertion.Verification
npm run typecheckclean;npx vitest run→ 2666 passed;npm run test:coverageabove floors (90.95 / 87.18 / 86.16 / 93.94).