Skip to content

test(web): pin the two #703 PR 3 residual guards (Stock key rotation, History void→adjust close) - #714

Merged
mforce merged 2 commits into
mainfrom
test/703-pr3-residual-guards
Sep 8, 2026
Merged

mforce merged 2 commits into
mainfrom
test/703-pr3-residual-guards

Conversation

@mforce

@mforce mforce commented Sep 8, 2026

Copy link
Copy Markdown
Owner

Closes #708 and #709 — both test-only; the shipped code is correct.

What

Mutation evidence (driver-run)

Verification

  • npm run typecheck clean; npx vitest run → 2666 passed; npm run test:coverage above floors (90.95 / 87.18 / 86.16 / 93.94).
  • Test-only: no product change; existing tests unchanged.

)

The #163 clearKey-before-refresh ordering is ungated by current(): the key rotates even when the write-off dialog is dismissed before the write settles, so a reopened same-lot dialog cannot reuse the spent key. The pre-existing 'even if the refresh fails' test exercises only the non-superseded path. Verified: a mutant moving clearKey below the current() gate reddens this test; the literal issue mutant (clearKey below the refresh try/catch, above the gate) is an equivalent mutant (the refresh is caught, so only position vs the gate is observable).
)

Voiding an entry whose adjust dialog is open force-closes that dialog on the void's SUCCESS path; the 409 twin was pinned by #491 tests, the success twin was not. Verified: deleting the success-branch close reddens this test.
@coderabbitai

coderabbitai Bot commented Sep 8, 2026

Copy link
Copy Markdown

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: f1c48b68-9e30-40ab-9aae-b1e1b91d4edd


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

test(web): pin Stock write-off's clearKey-before-refresh ordering (#703 PR 3 residual)

1 participant