Repository navigation
fix(i18n): tl glossary uses the standard passive of ilagay - #813
Merged
Merged
Conversation
glossaryDiscountDef ended "hindi ilinalagay", which metathesises the -in- infix. The standard imperfective passive is inilalagay (i- + -in- + CV reduplication of lagay). The catalog already uses that pattern elsewhere -- tl.ts:305 reads "ang iyong mga inilagay" -- so this was the locale disagreeing with itself, which is the class #688 exists for. Raised by an automated reviewer during #720 and deliberately left alone then, because #720 had no native speaker and substituting one non-native guess for another is not an improvement. Settled now on the internal inconsistency rather than on the reviewer's say-so.
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
mforce
pushed a commit
that referenced
this pull request
Sep 16, 2026
🤖 I have created a release *beep* *boop* --- ## [0.1.2](v0.1.1...v0.1.2) (2026-09-16) ### Features * **data:** standardize business record chronology ([#820](#820)) ([6231b31](6231b31)) * **infra:** optional leader-lease endpoint for pooled deploys ([#869](#869)) ([e9bc6a7](e9bc6a7)) * **sim:** seed a second farm for the README dashboard capture ([#867](#867)) ([de407c6](de407c6)) * **web:** adopt MUI, themed from the farm palette tokens ([#674](#674)) ([#860](#860)) ([6c83c5c](6c83c5c)) * **web:** convert Daily entry to MUI, field-first on the phone ([#888](#888)) ([b66f8b8](b66f8b8)) * **web:** convert the Dashboard and app shell to MUI ([#829](#829)) ([#883](#883)) ([2e94277](2e94277)) * **web:** retire the Slack-blue link colour for ink + a rule underline ([#884](#884)) ([c08f9d8](c08f9d8)) * **web:** serve a per-request CSP nonce so Emotion's styles apply under style-src 'self' ([#874](#874)) ([ba4e6f3](ba4e6f3)) * **web:** visual language theme overrides for the MUI revamp ([#864](#864)) ([#882](#882)) ([0bb6b73](0bb6b73)) * **web:** whole-app MUI baseline, theme policy guard and the [#740](#740) phone action rule ([#823](#823)) ([#871](#871)) ([af565e4](af565e4)) ### Bug fixes * **auth:** fail closed on unresolved flock-scope actors ([#787](#787)) ([#868](#868)) ([16d0350](16d0350)) * **auth:** make farm configuration owner-only ([#870](#870)) ([42f9036](42f9036)) * **e2e:** repoint the canary at the markup two PRs replaced ([#844](#844)) ([18b45dc](18b45dc)) * **i18n:** tl glossary uses the standard passive of ilagay ([#813](#813)) ([20dec10](20dec10)), closes [#738](#738) * **sim:** stop the k6-baseline EXIT trap masking a clean run as failed ([#838](#838)) ([f5ec96f](f5ec96f)) * **web:** declare the rule tokens the Dashboard reads, and guard undeclared custom properties ([#885](#885)) ([5bead1f](5bead1f)) ### Performance * **ci:** start the serialized integration collection first ([#861](#861)) ([1dcc7f6](1dcc7f6)), closes [#839](#839) ### Documentation * **auth:** record the OAuth 2.1 decision for MCP authentication ([#801](#801)) ([0510854](0510854)) * **designs:** MUI revamp design doc, component map, layout system, IA ([#862](#862)) ([da49481](da49481)) * **readme:** recapture the daily entry, reports and sales screenshots ([#865](#865)) ([f18e336](f18e336)) * **specs:** correct the sales_order_items column list in §10.5 ([#812](#812)) ([afe4a02](afe4a02)), closes [#737](#737) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: cluckwork-lockfix[bot] <309265648+cluckwork-lockfix[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
web/src/i18n/tl.tsglossaryDiscountDefended"hindi ilinalagay". The standard imperfective passive of ilagay isinilalagay—i-+ the-in-infix + CV reduplication of the root.ilinalagaymetathesises the infix; it is attested in some usage but is not the standard form.The decisive evidence is internal, not external. The same catalog already uses the standard pattern:
tl.ts:305reads "Nananatili ang iyong mga inilagay". So this was the locale disagreeing with itself about the same verb, which is precisely the class #688 exists for — and #688's whole point is that nothing mechanical catches it, becausecatalogParitycompares key sets and a value can drift freely.Why it was not fixed when it was raised
An automated reviewer flagged it during #720 (PR #734) and marked it SUSPECTED, which was honest — neither the reviewer nor the driver is a native speaker. It was filed to #738 for the native-speaker pass rather than changed, on the correct principle that substituting one non-native guess for another is not an improvement.
Two things changed. The native-speaker es/tl review was declined by the owner on 2026-09-13 (#182), so there is no pass to wait for. And the internal inconsistency above is a stronger argument than the reviewer's: it does not require judging Tagalog from outside, only noticing that the catalog contradicts itself.
The other half of #738 is deliberately NOT changed
Item 2 asked whether
esshould use por encima de rather than sobre for "above list". CodeRabbit raised it as an internal inconsistency, it was refuted with evidence, and the reviewer withdrew it — all five keys agree with each other (aboveList,glossaryAboveListTerm,listPriceHintAbove,listPriceHintAboveNoPct, and the help prose all read "Sobre el precio de lista").What remains is a style preference, not a defect, and there is no internal contradiction to settle it. Changing it would be exactly the non-native substitution this PR's first half avoided. Left as written.
Verification
npm run typecheck— clean.npx vitest run src/i18n— 316 tests, 8 files, all passing, includingcatalogParityandbadgeCase.grepconfirms one occurrence in the repo; no other string carried the variant.No screenshot is attached despite the #662 rule. That rule's trigger is what a reader can no longer check from the diff; this is a single word in a string literal, fully legible in the diff, with no layout, state or styling change.
Closes #738