fix: resolve three bugs in font lookup, subfont parsing, and PDF parsing#301
Merged
Conversation
jschueller
commented
Jun 24, 2026
jschueller
commented
Contributor
- FontManager: capture actual resolved path from FileFinder::lookup instead of storing the format array element (nullptr for exact match)
- Subfont: avoid forming pointer before array when gcount() < 2
- PDFParser: validate object types before popping from vector
Owner
|
Thanks for the PR. I'll have a look later today. |
mgieseki
reviewed
Jun 24, 2026
Owner
|
Your changes are fine. Please drop variable |
- FontManager: capture actual resolved path from FileFinder::lookup instead of storing the format array element (nullptr for exact match) - Subfont: avoid forming pointer before array when gcount() < 2 - PDFParser: validate object types before popping from vector
Owner
|
Thanks again for tracking down the issues and for providing the PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.