Fix header regex.#115
Merged
Merged
Conversation
The previous regex would match any number of instances of any of the supported SHA formats, e.g. SHA111. Instead of matching any number, we want to match optionally one. Also added some tests that this rejects invalid digest formats.
packrat386
force-pushed
the
fix_header_regex
branch
from
4465f50 to
739cf85
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The previous regex would match any number of instances of any of the
supported SHA formats, e.g. SHA111. Instead of matching any number, we
want to match optionally one.
Also added some tests that this rejects invalid digest formats.