Fixed build.yaml inconsistency#27
Merged
mhbuehler merged 1 commit intommqna-audio-queryfrom Dec 7, 2024
Merged
Conversation
Signed-off-by: Melanie Buehler <melanie.h.buehler@intel.com>
ashahba
reviewed
Dec 6, 2024
| extends: multimodalqna | ||
| image: ${REGISTRY:-opea}/dataprep-multimodal-redis:${TAG:-latest} | ||
| whisper-service: | ||
| whisper: |
Collaborator
There was a problem hiding this comment.
I'd make sure there are no references in the repo or GenAIExamples for this service name if we chage it.
Owner
Author
There was a problem hiding this comment.
That's what I did and I saw the references in the compose.yaml files, but @dmsuehir thinks those don't have to be changed and thus the READMEs and other refs shouldn't have to either.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixed name of whisper image in build.yaml.
Issues
RFC
Type of change
Dependencies
N/A
Tests
This should fix the failing "Compose file and dockerfile path checking" test