Repository navigation
fix(author): fall back to twitter:creator - #874
Merged
Merged
Conversation
Print/share buttons and Elsevier rights links were winning author. Reject that chrome, read twitter:creator, and collect Co-authored-by: Cursor <cursoragent@cursor.com> #author-group names when citation_author is missing.
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Drop the Elsevier #author-group / xocs selectors. JATS .given-name + .surname is what the markup actually shares. Co-authored-by: Cursor <cursoragent@cursor.com>
Site-specific Print/rights strings do not belong in isAuthor. twitter:creator and given-name/surname already cover the cases. Co-authored-by: Cursor <cursoragent@cursor.com>
Drop given-name/surname HTML scraping. Sites that omit citation_author / schema.org / twitter:creator are not patched with publisher CSS. Co-authored-by: Cursor <cursoragent@cursor.com>
twitter: creator is always a handle; default author() already strips @ Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Kikobeats
marked this pull request as ready for review
August 17, 2026 17:13
Collaborator
|
Caution CodeRabbit couldn't update its existing comment. The review summary may be out of date. Error details |
logo-favicon only accepts ico/png; this fixture's icons are jpg Co-authored-by: Cursor <cursoragent@cursor.com>
Pin jewish-business-news to the HTML logo instead of a network-dependent favicon fallback. Co-authored-by: Cursor <cursoragent@cursor.com>
logo-favicon reachability is not deterministic in CI. Co-authored-by: Cursor <cursoragent@cursor.com>
2 of 3 tasks
markharding
pushed a commit
to futo-org/Harbor
that referenced
this pull request
Oct 13, 2026
This PR contains the following updates: | Package | Change | [Age](https://docs.renovatebot.com/merge-confidence/) | [Confidence](https://docs.renovatebot.com/merge-confidence/) | |---|---|---|---| | [metascraper](https://metascraper.js.org) ([source](https://github.com/microlinkhq/metascraper)) | [`5.51.1` → `5.58.4`](https://renovatebot.com/diffs/npm/metascraper/5.51.1/5.58.4) |  |  | --- ### Release Notes <details> <summary>microlinkhq/metascraper (metascraper)</summary> ### [`v5.58.4`](https://github.com/microlinkhq/metascraper/blob/HEAD/CHANGELOG.md#5584-2026-10-09) [Compare Source](microlinkhq/metascraper@v5.58.1...v5.58.4) **Note:** Version bump only for package metascraper ### [`v5.58.1`](https://github.com/microlinkhq/metascraper/blob/HEAD/CHANGELOG.md#5581-2026-09-17) [Compare Source](microlinkhq/metascraper@v5.56.2...v5.58.1) ##### Bug Fixes - **metascraper-instagram:** prefer 180px apple-touch logo ([#​882](microlinkhq/metascraper#882)) ([a586af5](microlinkhq/metascraper@a586af5)) - use [@​kikobeats/got](https://github.com/kikobeats/got) to support Node.js 24.20 ([#​881](microlinkhq/metascraper#881)) ([41a626b](microlinkhq/metascraper@41a626b)), closes [nodejs/node#64847](nodejs/node#64847) ### [`v5.56.2`](https://github.com/microlinkhq/metascraper/blob/HEAD/CHANGELOG.md#5570-2026-08-19) [Compare Source](microlinkhq/metascraper@v5.56.1...v5.56.2) ##### Features - add metascraper-imdb ([#​876](microlinkhq/metascraper#876)) ([b10eabb](microlinkhq/metascraper@b10eabb)) #### [5.56.2](microlinkhq/metascraper@v5.56.1...v5.56.2) (2026-08-17) **Note:** Version bump only for package metascraper #### [5.56.1](microlinkhq/metascraper@v5.56.0...v5.56.1) (2026-08-17) ##### Bug Fixes - **author:** fall back to twitter:creator ([#​874](microlinkhq/metascraper#874)) ([d1ec557](microlinkhq/metascraper@d1ec557)), closes [#author-group](https://github.com/microlinkhq/metascraper/issues/author-group) [#author-group](https://github.com/microlinkhq/metascraper/issues/author-group) ### [`v5.56.1`](https://github.com/microlinkhq/metascraper/blob/HEAD/CHANGELOG.md#5570-2026-08-19) [Compare Source](microlinkhq/metascraper@v5.55.2...v5.56.1) ##### Features - add metascraper-imdb ([#​876](microlinkhq/metascraper#876)) ([b10eabb](microlinkhq/metascraper@b10eabb)) #### [5.56.2](microlinkhq/metascraper@v5.56.1...v5.56.2) (2026-08-17) **Note:** Version bump only for package metascraper #### [5.56.1](microlinkhq/metascraper@v5.56.0...v5.56.1) (2026-08-17) ##### Bug Fixes - **author:** fall back to twitter:creator ([#​874](microlinkhq/metascraper#874)) ([d1ec557](microlinkhq/metascraper@d1ec557)), closes [#author-group](https://github.com/microlinkhq/metascraper/issues/author-group) [#author-group](https://github.com/microlinkhq/metascraper/issues/author-group) ### [`v5.55.2`](https://github.com/microlinkhq/metascraper/blob/HEAD/CHANGELOG.md#5560-2026-08-15) [Compare Source](microlinkhq/metascraper@v5.55.1...v5.55.2) ##### Features - add metascraper-citation ([#​873](microlinkhq/metascraper#873)) ([31bceb1](microlinkhq/metascraper@31bceb1)) #### [5.55.2](microlinkhq/metascraper@v5.55.1...v5.55.2) (2026-08-13) ##### Bug Fixes - **helpers:** keep CGI + in query strings ([#​872](microlinkhq/metascraper#872)) ([4743562](microlinkhq/metascraper@4743562)) #### [5.55.1](microlinkhq/metascraper@v5.55.0...v5.55.1) (2026-08-10) ##### Bug Fixes - **youtube:** date a video by its upload date ([#​869](microlinkhq/metascraper#869)) ([7040d5c](microlinkhq/metascraper@7040d5c)) ### [`v5.55.1`](https://github.com/microlinkhq/metascraper/blob/HEAD/CHANGELOG.md#5560-2026-08-15) [Compare Source](microlinkhq/metascraper@v5.55.0...v5.55.1) ##### Features - add metascraper-citation ([#​873](microlinkhq/metascraper#873)) ([31bceb1](microlinkhq/metascraper@31bceb1)) #### [5.55.2](microlinkhq/metascraper@v5.55.1...v5.55.2) (2026-08-13) ##### Bug Fixes - **helpers:** keep CGI + in query strings ([#​872](microlinkhq/metascraper#872)) ([4743562](microlinkhq/metascraper@4743562)) #### [5.55.1](microlinkhq/metascraper@v5.55.0...v5.55.1) (2026-08-10) ##### Bug Fixes - **youtube:** date a video by its upload date ([#​869](microlinkhq/metascraper#869)) ([7040d5c](microlinkhq/metascraper@7040d5c)) ### [`v5.55.0`](https://github.com/microlinkhq/metascraper/blob/HEAD/CHANGELOG.md#5560-2026-08-15) [Compare Source](microlinkhq/metascraper@v5.54.1...v5.55.0) ##### Features - add metascraper-citation ([#​873](microlinkhq/metascraper#873)) ([31bceb1](microlinkhq/metascraper@31bceb1)) #### [5.55.2](microlinkhq/metascraper@v5.55.1...v5.55.2) (2026-08-13) ##### Bug Fixes - **helpers:** keep CGI + in query strings ([#​872](microlinkhq/metascraper#872)) ([4743562](microlinkhq/metascraper@4743562)) #### [5.55.1](microlinkhq/metascraper@v5.55.0...v5.55.1) (2026-08-10) ##### Bug Fixes - **youtube:** date a video by its upload date ([#​869](microlinkhq/metascraper#869)) ([7040d5c](microlinkhq/metascraper@7040d5c)) ### [`v5.54.1`](https://github.com/microlinkhq/metascraper/blob/HEAD/CHANGELOG.md#5550-2026-08-09) [Compare Source](microlinkhq/metascraper@v5.54.0...v5.54.1) ##### Features - **helpers:** pass propName to validate ([#​868](microlinkhq/metascraper#868)) ([8e0a75f](microlinkhq/metascraper@8e0a75f)) #### [5.54.1](microlinkhq/metascraper@v5.54.0...v5.54.1) (2026-08-07) **Note:** Version bump only for package metascraper ### [`v5.54.0`](https://github.com/microlinkhq/metascraper/blob/HEAD/CHANGELOG.md#5550-2026-08-09) [Compare Source](microlinkhq/metascraper@v5.53.0...v5.54.0) ##### Features - **helpers:** pass propName to validate ([#​868](microlinkhq/metascraper#868)) ([8e0a75f](microlinkhq/metascraper@8e0a75f)) #### [5.54.1](microlinkhq/metascraper@v5.54.0...v5.54.1) (2026-08-07) **Note:** Version bump only for package metascraper ### [`v5.53.0`](https://github.com/microlinkhq/metascraper/blob/HEAD/CHANGELOG.md#5540-2026-08-07) [Compare Source](microlinkhq/metascraper@v5.52.1...v5.53.0) ##### Features - **helpers:** add rule-level validate (like test) ([#​866](microlinkhq/metascraper#866)) ([d40856b](microlinkhq/metascraper@d40856b)) #### [5.53.1](microlinkhq/metascraper@v5.53.0...v5.53.1) (2026-08-02) ##### Bug Fixes - keep the favicon body under reachable-url v2 ([#​865](microlinkhq/metascraper#865)) ([ce4536f](microlinkhq/metascraper@ce4536f)) ### [`v5.52.1`](https://github.com/microlinkhq/metascraper/blob/HEAD/CHANGELOG.md#5530-2026-07-30) [Compare Source](microlinkhq/metascraper@v5.52.0...v5.52.1) ##### Features - **helpers:** read the declared protocol instead of resolving it ([#​864](microlinkhq/metascraper#864)) ([2d72298](microlinkhq/metascraper@2d72298)) #### [5.52.1](microlinkhq/metascraper@v5.52.0...v5.52.1) (2026-07-29) **Note:** Version bump only for package metascraper ### [`v5.52.0`](https://github.com/microlinkhq/metascraper/blob/HEAD/CHANGELOG.md#5530-2026-07-30) [Compare Source](microlinkhq/metascraper@v5.51.1...v5.52.0) ##### Features - **helpers:** read the declared protocol instead of resolving it ([#​864](microlinkhq/metascraper#864)) ([2d72298](microlinkhq/metascraper@2d72298)) #### [5.52.1](microlinkhq/metascraper@v5.52.0...v5.52.1) (2026-07-29) **Note:** Version bump only for package metascraper </details> --- ### Configuration 📅 **Schedule**: (UTC) - Branch creation - "before 9am on tuesday" - Automerge - At any time (no schedule defined) 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate CLI](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0NC4xMzMuMCIsInVwZGF0ZWRJblZlciI6IjQ0LjEzMy4wIiwidGFyZ2V0QnJhbmNoIjoiZGV2ZWxvcCIsImxhYmVscyI6WyJkZXBlbmRlbmNpZXMiLCJyZW5vdmF0ZSJdfQ==--> Reviewed-on: https://code.futo.org/harbor/harbor/pulls/1815
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
twitter:creatoras a last-resort author when JSON-LD /meta[name=author]/article:author/ itemprop / byline heuristics do not produce a value.author()still strips the@prefix, so@mayoclinicbecomesmayoclinic.meta[name=author]continues to win over the handle.Test plan
metascraper-author: Mayo Clinic usestwitter:creator;meta[name=author]wins when both existnull(bfi, business-today, segment-academy)logofrom the snapshot validate it withurl()Note
Low Risk
Metadata heuristics only; behavior changes are additive fallbacks and test harness narrowing, with no auth or data-path impact.
Overview
Author extraction now falls back to
meta[name="twitter:creator"]andmeta[property="twitter:creator"]after existing JSON-LD, meta, and DOM heuristics, so pages like Mayo Clinic can resolve an author when nothing else matches. Values still go through the existingauthor()helper (e.g.@mayoclinic→mayoclinic); higher-priority sources such asmeta[name="author"]are unchanged.Logo adds a rule for
[itemprop="logo"] imgsrc, which can pick up nested microdata logos (e.g. jewish-business-news) without favicon/manifest plugins.Tests:
metascraper-authorruns AVA unit tests for the Twitter fallback and precedence; integration suites dropmetascraper-logo-favicon/metascraper-manifest, assertlogoexplicitly (oftennull), and refresh snapshots where author was previouslynull.Reviewed by Cursor Bugbot for commit bd0439e. Bugbot is set up for automated code reviews on this repo. Configure here.