Skip to content

Updating DiagnosticSource to latest version#2091

Merged
eddynaka merged 3 commits intodevelopfrom
users/ednakamu/updating-diagnosticsource
Oct 14, 2020
Merged

Updating DiagnosticSource to latest version#2091
eddynaka merged 3 commits intodevelopfrom
users/ednakamu/updating-diagnosticsource

Conversation

@eddynaka
Copy link
Contributor

Fix Issue # .

Changes

(Please provide a brief description of the changes here.)

Checklist

  • I ran Unit Tests locally.
  • CHANGELOG.md updated with one line description of the fix, and a link to the original issue if available.

For significant contributions please make sure you have completed the following items:

  • Design discussion issue #
  • Changes in public surface reviewed

The PR will trigger build, unit tests, and functional tests automatically. Please follow these instructions to build and test locally.

Notes for authors:

  • FxCop and other analyzers will fail the build. To see these errors yourself, compile localy using the Release configuration.

Notes for reviewers:

  • We support comment build triggers
    • /AzurePipelines run will queue all builds
    • /AzurePipelines run <pipeline-name> will queue a specific build

@eddynaka eddynaka self-assigned this Oct 14, 2020
@eddynaka eddynaka requested a review from cijothomas October 14, 2020 18:23
@cijothomas
Copy link
Contributor

/azurepipelines run

@cijothomas
Copy link
Contributor

/AzurePipelines run

Copy link
Contributor

@cijothomas cijothomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changelog can be corrected to say rc2

@azure-pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

1 similar comment
@azure-pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants