Unexpected behaviour of 'Airlock' tab on LHS of UI

[TonyWildish-BH]

Describe the bug
The UI has an 'Airlock' tab on the left, and I'm an Airlock Manager for all our workspaces.

If I'm in a workspace, I can see the airlock requests there, and clicking on 'Awaiting my review' will show me any pending requests. See first screenshot for an example.

If I then go to the TRE view, then to the Airlock tab, then to 'Awaiting my review', I would expect to see all the airlock requests that are pending review, including the one above. However, the list is empty. See second screenshot.

My expectation is that, in the global view, I should be able to see all airlock requests that are pending my review, in all workspaces. Is that the intended behaviour, or have I misunderstood?

Steps to reproduce

1. Ask a user to create an airlock request in a workspace you are Airlock Manager for
2. Verify that you can see the request waiting for your review from the Airlock tab in the workspace view
3. Verify that you cannot see the request waiting for your review from the Airlock tab in the global view.

Azure TRE release version (e.g. v0.14.0 or main):
v0.21.0

Deployed Azure TRE components - click the (i) in the UI:
UI Version: 0.7.0
API Version: 0.21.1

[marrobi]

Hi Tony, yes, it should, do the other tabs work? Can you check if there any errors in the browser dev tools?

Thanks.

[TonyWildish-BH]

Good question. No, there's another error, the 'All Requests' tab only shows my requests, not the dozens of others I should see as an Airlock Manager.

There are no errors showing in my browser dev tools.

[marrobi]

Can you check what results you get via swagger?

https://<tre_url>/api/docs#/requests/Get_requests_api_requests_get

Thanks

[TonyWildish-BH]

Swagger gives me identical results to the UI. If I don't filter, I get only my own requests. If I filter by 'in review', I get none - which is consistent, since I don't have any requests in review, but it's not what I expect, since there is a request in review for which I am the Airlock Manager.

[marrobi]

I have found a bug, but not sure it will fix the issue you are seeing. Can you confirm when using swagger this is set?

[marrobi]

Ok, think I've got it, an additional ? has crept into the query.

also fixed some other things. @TonyWildish-BH are you able to validate this PR resolves the issue you are seeing? The UI fix would be the easiest to test.

[TonyWildish-BH]

I had the airlock_manager set to true, yes.

I can test the PR , probably tomorrow, thanks for the prompt action.

[marrobi]

@TonyWildish-BH did you get chance to test this?