Skip to content

Add loading spinner to shared services page#4718

Merged
marrobi merged 10 commits intomainfrom
jc-wk/ui-shared-services-loading-spinner
Nov 7, 2025
Merged

Add loading spinner to shared services page#4718
marrobi merged 10 commits intomainfrom
jc-wk/ui-shared-services-loading-spinner

Conversation

@JC-wk
Copy link
Copy Markdown
Collaborator

@JC-wk JC-wk commented Oct 16, 2025

Resolves #4704

What is being addressed

When loading shared services ui hard to see on this gif but "This TRE has no shared services" briefly flashes up before the services load
20251016-1013-39 5962347

How is this addressed

  • Added a loading spinner
    20251016-1003-19 4193635

@github-actions
Copy link
Copy Markdown

github-actions bot commented Oct 16, 2025

Unit Test Results

0 tests   0 ✅  0s ⏱️
0 suites  0 💤
0 files    0 ❌

Results for commit 9b83eea.

♻️ This comment has been updated with latest results.

@JC-wk JC-wk marked this pull request as ready for review October 16, 2025 10:15
@JC-wk JC-wk requested a review from a team as a code owner October 16, 2025 10:15
@JC-wk JC-wk marked this pull request as draft October 16, 2025 10:28
@JC-wk
Copy link
Copy Markdown
Collaborator Author

JC-wk commented Oct 16, 2025

I am going to rework the code to make it match to the other pages using a switch statement

@JC-wk
Copy link
Copy Markdown
Collaborator Author

JC-wk commented Oct 16, 2025

done

@JC-wk JC-wk marked this pull request as ready for review October 16, 2025 10:48
@JC-wk JC-wk requested a review from marrobi October 16, 2025 10:51
@JC-wk JC-wk added the ui TRE UI label Oct 17, 2025
@marrobi marrobi requested a review from Copilot November 7, 2025 14:32
Copy link
Copy Markdown
Member

@marrobi marrobi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and LGTM. Thanks!

@marrobi
Copy link
Copy Markdown
Member

marrobi commented Nov 7, 2025

/test-force-approve 9b83eea

UI Only

@github-actions
Copy link
Copy Markdown

github-actions bot commented Nov 7, 2025

🤖 pr-bot 🤖

✅ Marking tests as complete (for commit 9b83eea)

(in response to this comment from @marrobi)

@marrobi marrobi enabled auto-merge (squash) November 7, 2025 14:34
Copy link
Copy Markdown
Collaborator

@SvenAelterman SvenAelterman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@marrobi marrobi merged commit 4df7f13 into main Nov 7, 2025
18 checks passed
@marrobi marrobi deleted the jc-wk/ui-shared-services-loading-spinner branch November 7, 2025 15:00
@JC-wk JC-wk review requested due to automatic review settings March 23, 2026 23:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ui TRE UI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Minor] [UI] When loading shared services page "This TRE has no shared services" briefly flashes up before the services appear

3 participants