Add role="group" to transcript focusable#3765
Merged
compulim merged 1 commit intomicrosoft:masterfrom Feb 25, 2021
Merged
Conversation
compulim
requested review from
a-b-r-o-w-n,
amal-khalaf,
beyackle,
corinagum,
cwhitten,
srinaath,
tdurnford and
tonyanziano
as code owners
corinagum
approved these changes
Feb 25, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog Entry
Fixed
role="group"to the focusable transcript to enablearia-activedescendant, by @compulim in PR #3765Description
Add
role="group"to transcript focusable element, to enablearia-activedescendantin macOS Safari + VoiceOver.Design
According to WAI-ARIA,
aria-activedescendantwill only work with one of the followingrole:applicationcompositewith subclass ofgridselectspinbuttontablistgrouptextboxcomboboxgridlistboxmenumenubarradiogrouprowsearchboxselectspinbuttontablisttoolbartreetreegridSpecific Changes
role="group"to the focusable of<BasicTranscript>I have added tests and executed them locallyCHANGELOG.mdI have updated documentationReview Checklist
CSS styles reviewed (minimal rules, noz-index)Documents reviewed (docs, samples, live demo)Internationalization reviewed (strings, unit formatting)package.jsonandpackage-lock.jsonreviewedSecurity reviewed (no data URIs, check for nonce leak)Tests reviewed (coverage, legitimacy)