Center align icon of send box button#3673
Conversation
corinagum
left a comment
There was a problem hiding this comment.
TBH I haven't gone through all tests and I'm trusting based off the code changes that test img updates are all valid haha. LGTM
|
Going through 415 images aren't quick without good tools. And I found a few bugs in our existing snapshots due to retries. I mean, if we run a test, it failed, we will retry. The snapshot counter will continue to cumulate. That means, snapshot Overall test is still verifying our work. But due to this, we lost 1 retry chance as a result because Anyway, will look into this issue in the future. p.s. I also removed all orphans I believe. |
Changelog Entry
Fixed
Description
The icon is not vertically centered. It is off by 1 pixel.
Design
Specific Changes
CHANGELOG.mdReview Checklist
Accessibility reviewed (tab order, content readability, alt text, color contrast)Browser and platform compatibilities reviewedCSS styles reviewed (minimal rules, noz-index)Documents reviewed (docs, samples, live demo)Internationalization reviewed (strings, unit formatting)package.jsonandpackage-lock.jsonreviewedSecurity reviewed (no data URIs, check for nonce leak)Tests reviewed (coverage, legitimacy)