Merged
Conversation
b50e03e to
b2c6e5c
Compare
tdurnford
approved these changes
Oct 5, 2022
11 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog Entry
Changed
microsoft-cognitiveservices-speech-sdk@1.23.0web-speech-cognitive-services@7.1.2Description
Bump
microsoft-cognitiveservices-speech-sdk@1.23.0andweb-speech-cognitive-services@7.1.2.Design
Bumping
web-speech-cognitive-services@7.1.2can be found at compulim/web-speech-cognitive-services#196.Importing from
/distrib/lib/*vs./distrib/es2015/*When producing bundle, importing code from
microsoft-cognitiveservices-speech-sdk/distrib/lib/*will yield smaller output size (30.5 MB) than from/distrib/es2015/*(39.5 MB).This behavior is not well understood. However, we are keeping our current
webpack.config.jsand continue to import from/distrib/lib/instead.Sample code from
/distrib/lib/src/common/Exports.jsSample code from
/distrib/es2015/src/common/Exports.jsSpecific Changes
createMicrophoneAudioConfigAndAudioContext.tsto match updated API from Speech SDKBump
microsoft-cognitiveservices-speech-sdk@1.23.0Bump
web-speech-cognitive-services@7.1.2CHANGELOG.mdReview Checklist
Accessibility reviewed (tab order, content readability, alt text, color contrast)CSS styles reviewed (minimal rules, noz-index)Documents reviewed (docs, samples, live demo)Internationalization reviewed (strings, unit formatting)package.jsonandpackage-lock.jsonreviewedSecurity reviewed (no data URIs, check for nonce leak)Tests reviewed (coverage, legitimacy)