Skip to content

High contrast: push button should be highlighted#4746

Merged
compulim merged 3 commits intomainfrom
fix-4718-ac-push-button-high-contrast
Jun 15, 2023
Merged

High contrast: push button should be highlighted#4746
compulim merged 3 commits intomainfrom
fix-4718-ac-push-button-high-contrast

Conversation

@compulim
Copy link
Contributor

@compulim compulim commented Jun 14, 2023

Fixes #4718.

Changelog Entry

Fixed

  • Fixes #4718. In high contrast mode, Adaptive Card buttons, when pushed, should highlighted properly, by @compulim, in PR #4746

Description

Update AC push button to be highlighted in high contrast mode.

Design

From MDN <system-color>, the Highlight and HighlightText pair will:

  • Highlight: Background of selected items
  • HighlightText: Text color of selected items

We also explicitly turned off forced-color-adjust, otherwise, it would look:

image

Specific Changes

  • Add styles for @media (forced-color: active)
  • Add tests
  • I have added tests and executed them locally
  • I have updated CHANGELOG.md
  • I have updated documentation

Review Checklist

This section is for contributors to review your work.

  • Accessibility reviewed (tab order, content readability, alt text, color contrast)
  • Browser and platform compatibilities reviewed
  • CSS styles reviewed (minimal rules, no z-index)
  • Documents reviewed (docs, samples, live demo)
  • Internationalization reviewed (strings, unit formatting)
  • package.json and package-lock.json reviewed
  • Security reviewed (no data URIs, check for nonce leak)
  • Tests reviewed (coverage, legitimacy)

@compulim compulim marked this pull request as ready for review June 14, 2023 23:11
tdurnford
tdurnford previously approved these changes Jun 14, 2023
@compulim compulim merged commit be67477 into main Jun 15, 2023
@compulim compulim deleted the fix-4718-ac-push-button-high-contrast branch June 15, 2023 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

2 participants