Retries for fetching snapshots#7317
Merged
achamayou merged 11 commits intomicrosoft:mainfrom Sep 29, 2025
Merged
Conversation
maxtropets
reviewed
Sep 29, 2025
achamayou
reviewed
Sep 29, 2025
achamayou
reviewed
Sep 29, 2025
achamayou
reviewed
Sep 29, 2025
achamayou
reviewed
Sep 29, 2025
achamayou
approved these changes
Sep 29, 2025
Co-authored-by: Amaury Chamayou <amaury@xargs.fr>
cjen1-msft
added
6.x-todo
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
cjen1-msft
added a commit
to cjen1-msft/CCF
that referenced
this pull request
Sep 30, 2025
Co-authored-by: Amaury Chamayou <amaury@xargs.fr>
cjen1-msft
added
the
backported
6 tasks
Copilot AI
added a commit
that referenced
this pull request
Mar 11, 2026
The test was added in #7317 but never added to a runner. The original logic was also broken: it stopped the primary before joining, so no StartupSeqnoIsOld response was ever produced and FetchSnapshot was never triggered - the expected retry/giving-up log messages could never appear. Redesign: use BackupSnapshotFetch with backup_snapshot_fetch_target_rpc_interface="primary_rpc_interface". The primary_rpc_interface lacks the SnapshotRead operator feature, so every fetch request returns HTTP 404, reliably driving the fetch_from_peer retry loop to log all three attempt messages and the "Exceeded maximum snapshot fetch retries … giving up" message. Also: - Add args.label suffix to avoid workspace collision - Inline txs construction (matches run_backup_snapshot_download style) - Use network.txs.issue instead of a separate txs variable - Collect matched patterns before removing to avoid list mutation during iteration - Register the test in schema.py alongside run_backup_snapshot_download Co-authored-by: eddyashton <6000239+eddyashton@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add retry path when fetching snapshots controlled with
command.join.fetch_snapshot_max_retriesandcommand.join.fetch_snapshot_retry_intervalin the config.(The current fetch prints an error message and returns a std::nullopt when it fails, so this PR wraps that response in a retry loop)