Fix crash in DXIL.dll caused by illegal DXIL intrinsic.#6302
Merged
python3kgae merged 6 commits intomicrosoft:mainfrom Feb 20, 2024
Merged
Fix crash in DXIL.dll caused by illegal DXIL intrinsic.#6302python3kgae merged 6 commits intomicrosoft:mainfrom
python3kgae merged 6 commits intomicrosoft:mainfrom
Conversation
Contributor
|
✅ With the latest revision this PR passed the Python code formatter. |
Contributor
|
✅ With the latest revision this PR passed the C/C++ code formatter. |
llvm-beanz
reviewed
Feb 14, 2024
llvm-beanz
reviewed
Feb 15, 2024
Collaborator
llvm-beanz
left a comment
llvm-beanz
left a comment
There was a problem hiding this comment.
One thing I missed on my last pass, and a cleanup nit.
Replace assert on illegal DXIL op with return illegal value. Check the illegal cases in validation. Fixes microsoft#6168
python3kgae
force-pushed
the
dxil_op_check
branch
from
47a10a8 to
1cd8042
Compare
pow2clk
reviewed
Feb 20, 2024
Collaborator
pow2clk
left a comment
pow2clk
left a comment
There was a problem hiding this comment.
Mostly speaking up for asserts
llvm-beanz
approved these changes
Feb 20, 2024
pow2clk
approved these changes
Feb 20, 2024
Collaborator
pow2clk
left a comment
pow2clk
left a comment
There was a problem hiding this comment.
Looks good given Chris's responses to my comments.
python3kgae
added a commit
that referenced
this pull request
Feb 22, 2024
tex3d
added a commit
to tex3d/DirectXShaderCompiler
that referenced
this pull request
Mar 14, 2024
…osoft#6302) (microsoft#6342)" This file deleted with conflicts from subsequent changes: tools/clang/test/LitDXILValidation/illegalDXILOp.ll This reverts commit 487080f.
tex3d
added a commit
that referenced
this pull request
Mar 14, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace assert on illegal DXIL op with return illegal value. Check the illegal cases in validation.
Fixes #6168