Merged
Conversation
Internal build that has DXC as a submodule and is built with a different VC toolset version fails after the pragma got moved up in commit 0b9acdb. Adding a duplicate pragma back at the original location makes both compiler versions happy.
tex3d
approved these changes
Jun 27, 2024
damyanp
approved these changes
Jun 27, 2024
pow2clk
pushed a commit
to pow2clk/DirectXShaderCompiler
that referenced
this pull request
Jul 16, 2024
pow2clk
pushed a commit
that referenced
this pull request
Jul 16, 2024
Merges the following changes into mesh nodes to fix a known bug that required a point release in the march release branch and also some build fixes for new visual studio diagnostics. 9ca52f4 Add duplicate pragma (#6732) 7809c0b Remove Windows C++ redist hack (#6692) 33277a1 Workaround broken GitHub runner images (#6683) 1b9a796 [Sema] Check FunctionDecl has identifier before getName. (#6439) (#6457)
SjMxr233
pushed a commit
to ShaderHelper/DirectXShaderCompiler
that referenced
this pull request
Jul 24, 2025
Internal build that has DXC as a submodule and that is built with a different VC toolset version started failing after the pragma got moved up in commit 0b9acdb. Adding a duplicate pragma back at the original location makes both compiler versions happy.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Internal build that has DXC as a submodule and that is built with a different VC toolset version started failing after the pragma got moved up in commit 0b9acdb. Adding a duplicate pragma back at the original location makes both compiler versions happy.