Remove experimental Cooperative Vector feature#8291
Open
damyanp wants to merge 12 commits intomicrosoft:mainfrom
Open
Remove experimental Cooperative Vector feature#8291damyanp wants to merge 12 commits intomicrosoft:mainfrom
damyanp wants to merge 12 commits intomicrosoft:mainfrom
Conversation
…ative vector operations - Deleted invalid and valid test cases for outer product accumulation. - Removed tests for matrix-vector multiplication and accumulation errors. - Cleaned up configuration files related to cooperative vector tests. - Updated the HCT database to remove references to obsolete operations.
…DXIL documentation and code
damyanp
commented
Mar 23, 2026
…lass This commit eliminates several validation rules related to Linalg operations that are no longer necessary. The removed rules include checks for constant flags, valid interpretation values, matrix layout constraints, and other related validations. This cleanup helps streamline the validation process and maintain code clarity.
alsepkow
reviewed
Mar 24, 2026
hekota
reviewed
Mar 24, 2026
Comment on lines
-2509
to
-2514
| enum class LinalgMatrixLayout : uint32_t { | ||
| RowMajor = 0, | ||
| ColumnMajor = 1, | ||
| MulOptimal = 2, | ||
| OuterProductOptimal = 3, | ||
| }; |
Member
There was a problem hiding this comment.
I think we'll need this for LinAlg Matrix.
Member
Author
There was a problem hiding this comment.
@V-FEXrt and I discussed this and figured it'd be ok to remove now. We'll almost certainly want to move it to a different location in the file (so it's next to the other linalg enums) and so I figure we'd want to do that at the same time as actually adding some code that uses it. At the moment this is completely unused.
Co-authored-by: Helena Kotas <hekotas@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The experimental Cooperative Vector feature has been superseded by LinAlg. This change removes the code supporting the old feature.
Fixes #8147