fix: Reapply parameter name standardization Revert revert 576#604
Closed
Prachig-Microsoft wants to merge 1 commit intodevfrom
Closed
fix: Reapply parameter name standardization Revert revert 576#604Prachig-Microsoft wants to merge 1 commit intodevfrom
Prachig-Microsoft wants to merge 1 commit intodevfrom
Conversation
This reverts commit 65bb07a.
![github-code-quality[bot]](https://avatars.githubusercontent.com/u/9919?s=60&v=4){kind=small}
Prachig-Microsoft
requested review from
Avijit-Microsoft,
Dongbumlee,
Prajwal-Microsoft,
Roopan-Microsoft,
Vinay-Microsoft,
aniaroramsft,
dgp10801,
nchandhi and
toherman-msft
as code owners
App/backend-api/Microsoft.GS.DPS.Host/Helpers/TelemetryHelper.cs
Dismissed
Show dismissed
Hide dismissed
Comment on lines
+53
to
+56
| catch (Exception ex) | ||
| { | ||
| _logger.LogError(ex, "Failed to track event: {EventName}", eventName); | ||
| } |
Comment on lines
+76
to
+79
| catch (Exception ex) | ||
| { | ||
| _logger.LogError(ex, "Failed to track exception"); | ||
| } |
Comment on lines
+101
to
+104
| catch (Exception ex) | ||
| { | ||
| _logger.LogError(ex, "Failed to track dependency: {DependencyName}", dependencyName); | ||
| } |
Comment on lines
+124
to
+127
| catch (Exception ex) | ||
| { | ||
| _logger.LogError(ex, "Failed to track metric: {MetricName}", metricName); | ||
| } |
Comment on lines
+146
to
+149
| catch (Exception ex) | ||
| { | ||
| _logger.LogError(ex, "Failed to set activity tag: {Key}", key); | ||
| } |
Comment on lines
+166
to
+169
| catch (Exception ex) | ||
| { | ||
| _logger.LogError(ex, "Failed to flush telemetry client"); | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates several GitHub Actions workflow files to standardize and clarify environment variable names related to Azure AI service locations and Log Analytics workspace IDs. It also introduces new workflows for template validation and Azure development deployments. The most significant changes are grouped below:
Standardization of Environment Variable Names:
Workflow Enhancements and Additions:
.github/workflows/azd-template-validation.ymlto automatically validate Azure Developer (azd) templates on a schedule and on demand, improving template reliability..github/workflows/azure-dev.ymlfor manual Azure development deployments, supporting streamlined dev/test scenarios.Parameter and Naming Updates:
.github/workflows/CI.ymlto useazureAiServiceLocationinstead ofaiDeploymentsLocationfor clarity and alignment with other workflows.These changes improve maintainability, reduce ambiguity, and enhance the automation and validation of Azure deployments in the CI/CD pipeline.## Purpose
Does this introduce a breaking change?
Golden Path Validation
Deployment Validation
What to Check
Verify that the following are valid
Other Information